From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 28/33] tools/libxl: Check if fdt_{first, next}_subnode are present in libfdt Date: Thu, 19 Mar 2015 19:42:26 +0000 Message-ID: <550B26A2.2060200@linaro.org> References: <1426793399-6283-1-git-send-email-julien.grall@linaro.org> <1426793399-6283-29-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YYgLH-0002pJ-Bc for xen-devel@lists.xenproject.org; Thu, 19 Mar 2015 19:42:55 +0000 Received: by wegp1 with SMTP id p1so65832583weg.1 for ; Thu, 19 Mar 2015 12:42:53 -0700 (PDT) In-Reply-To: <1426793399-6283-29-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Ian Jackson , stefano.stabellini@citrix.com, tim@xen.org, ian.campbell@citrix.com, Wei Liu List-Id: xen-devel@lists.xenproject.org Hi, On 19/03/15 19:29, Julien Grall wrote: > The functions fdt_{fisrt,next}_subnode may not be available because: > * It has been introduced in 2013 => Doesn't work on Wheezy > * The prototype exists but the functions are not exposed. Don't ask > why... > > The later has been fixed recently in the dtc repo [1] > > When the functions are not available, implement our own in order to use > them in a following patch. > > [1] git://git.kernel.org/pub/scm/utils/dtc/dtc.git > commit a4b093f7366fdb429ca1781144d3985fa50d0fbb > > Signed-off-by: Julien Grall > Cc: Ian Jackson > Cc: Wei Liu > > --- I forgot to add that this patch modify tools/configure.ac and therefore require to regenerate tools/configure. Regards, -- Julien Grall