All of lore.kernel.org
 help / color / mirror / Atom feed
From: "christophe.ricard" <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Peter Hüwe" <PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
Cc: ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
	tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
	jean-luc.blanc-qxv4g6HH51o@public.gmane.org,
	benoit.houyere-qxv4g6HH51o@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
	jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
Subject: Re: [PATCH] st33zp24 fix when using irq mode
Date: Thu, 19 Mar 2015 22:34:24 +0100	[thread overview]
Message-ID: <550B40E0.6050708@gmail.com> (raw)
In-Reply-To: <201503192234.32531.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>

Hi Peter,

Basically if running a TPM command with a long enough duration (> 
timeout_c), the answer will never be read correctly.
This only appear if using irq mode.

I am actually doing the backport to james tree at the moment and will 
send it later on tonight.

I will send this directly without including stable@...

Best Regards
Christophe

On 19/03/2015 22:34, Peter Hüwe wrote:
> Hi,
>
> great timing :) I just sent the pull request for 4.1 out yesterday :)
> But thanks for spotting and fixing it.
> Found bugs are good bugs, and fixed ones are even better.
>
> Am Donnerstag, 19. März 2015, 22:15:08 schrieb Christophe Ricard:
>> Hi,
>>
>> Please find in this patch a fix that fix an improper command completion
>> wait. This patch apply on top of for-james branch
>> tpm/tpm_infineon: Use struct dev_pm_ops for power management
>> 6b37729bd184fdd44f144c6cc4951b06b55bcf4b
>>
>> *** Note: This bug is also present in kernel 4.0 but will not apply as the
>> driver structure changed between kernel 4.0 and kernel 4.1.
>>
>> A backported version is also going to be sent to <stable-u79uwXL29TZUIDd8j+nm9g@public.gmane.org.org> ?
> Are kernels < 4.0 also affected or was this code introduced in 4.0 ?
>
> How critical is the mentioned 'critical failure' ? What will happen?
> How often does it happen?
>
> If this thing is big enough and kernels < 4.0 are not affected we can try to
> get it into 4.0 still, so no stable. (but I still need the backport :) )
>
>
> If it won't hit 4.0 then backport to 4.0.1 is needed,
> which will be sent to stable@...
> with the upstream commit mentioned.
>
>
> See
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/stable_kernel_rules.txt
>
> Thanks,
> Peter
>
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2015-03-19 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 21:15 [PATCH] st33zp24 fix when using irq mode Christophe Ricard
     [not found] ` <1426799709-9696-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2015-03-19 21:15   ` [PATCH] tpm/st33zp24: Add proper wait for ordinal duration in case of " Christophe Ricard
2015-03-19 21:34   ` [PATCH] st33zp24 fix when using " Peter Hüwe
     [not found]     ` <201503192234.32531.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2015-03-19 21:34       ` christophe.ricard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550B40E0.6050708@gmail.com \
    --to=christophe.ricard-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=PeterHuewe-Mmb7MZpHnFY@public.gmane.org \
    --cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
    --cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
    --cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.