From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 11/13] block: Add blk_remove_all_bs()
Date: Thu, 19 Mar 2015 16:16:46 -0600 [thread overview]
Message-ID: <550B4ACE.9080903@redhat.com> (raw)
In-Reply-To: <1425413591-31413-12-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
On 03/03/2015 01:13 PM, Max Reitz wrote:
> When bdrv_close_all() is called, instead of force-closing all root
> BlockDriverStates, it is better to just drop the reference from all
> BlockBackends and let them be closed automatically. This prevents BDS
> from getting closed that are still referenced by other BDS, which may
> result in loss of cached data.
>
> This patch adds a function for doing that, but does not yet incorporate
> it in bdrv_close_all().
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/block-backend.c | 13 +++++++++++++
> include/sysemu/block-backend.h | 1 +
> 2 files changed, 14 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-19 22:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 20:12 [Qemu-devel] [PATCH v5 00/13] block: Rework bdrv_close_all() Max Reitz
2015-03-03 20:12 ` [Qemu-devel] [PATCH v5 01/13] iotests: Move _filter_nbd into common.filter Max Reitz
2015-03-04 6:11 ` Fam Zheng
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 02/13] iotests: Make redirecting qemu's stderr optional Max Reitz
2015-03-04 6:19 ` Fam Zheng
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 03/13] iotests: Add test for eject under NBD server Max Reitz
2015-03-04 6:30 ` Fam Zheng
2015-03-04 14:02 ` Max Reitz
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 04/13] quorum: Fix close path Max Reitz
2015-03-04 6:32 ` Fam Zheng
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 05/13] block: Move BDS close notifiers into BB Max Reitz
2015-03-19 18:17 ` Eric Blake
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 06/13] block: Use blk_remove_bs() in blk_delete() Max Reitz
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 07/13] blockdev: Use blk_remove_bs() in do_drive_del() Max Reitz
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 08/13] block: Make bdrv_close() static Max Reitz
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 09/13] block: Add list of all BlockDriverStates Max Reitz
2015-03-19 19:15 ` Eric Blake
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 10/13] blockdev: Keep track of monitor-owned BDS Max Reitz
2015-03-19 19:18 ` Eric Blake
2015-03-20 8:04 ` Markus Armbruster
2015-03-20 12:52 ` Max Reitz
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 11/13] block: Add blk_remove_all_bs() Max Reitz
2015-03-19 22:16 ` Eric Blake [this message]
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 12/13] block: Rewrite bdrv_close_all() Max Reitz
2015-03-03 20:13 ` [Qemu-devel] [PATCH v5 13/13] iotests: Add test for multiple BB on BDS tree Max Reitz
2015-03-04 12:42 ` [Qemu-devel] [PATCH v5 00/13] block: Rework bdrv_close_all() Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B4ACE.9080903@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.