From: Ying Xue <ying.xue@windriver.com>
To: David Miller <davem@davemloft.net>, <marcelo.leitner@gmail.com>
Cc: <richard.alpe@ericsson.com>, <jon.maloy@ericsson.com>,
<netdev@vger.kernel.org>, <tipc-discussion@lists.sourceforge.net>,
<erik.hugne@ericsson.com>
Subject: Re: [PATCH v2] tipc: fix build issue when building without IPv6
Date: Fri, 20 Mar 2015 10:09:26 +0800 [thread overview]
Message-ID: <550B8156.3020400@windriver.com> (raw)
In-Reply-To: <20150319.160658.1294624225284354605.davem@davemloft.net>
On 03/20/2015 04:06 AM, David Miller wrote:
> From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> Date: Thu, 19 Mar 2015 16:47:58 -0300
>
>> We can't directly call ipv6_sock_mc_join() but should use the stub
>> instead and protect it around IS_ENABLED.
>>
>> Fixes: d0f91938bede ("tipc: add ip/udp media type")
>> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>
Sorry, this patch doesn't work at all especially when IPV6=m and TIPC=y. For
example, when we use the combination of the kernel config options, error appears
like:
net/built-in.o: In function `tipc_udp_send_msg':
/home/ying/work/tipc/tipc2.0/net-next-2.6-debug/net/tipc/udp_media.c:196:
undefined reference to `ip6_dst_lookup'
make: *** [vmlinux] Error 1
Instead, I ever tried to fix the issue several days ago. Please refer to the thread:
https://patchwork.ozlabs.org/patch/448836/
According to the suggestion David gave lastly, we should separate the UDP media
as an independent module, make TIPC_MEDIA_UDP depend on (IPV6 || IPV6=n), and
mark TIPC_MEDIA_UDP tristate. Now I am busy doing this following the proposal.
Regards,
Ying
> This works better, applied, thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2015-03-20 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 15:13 [PATCH] tipc: fix build issue when building without IPv6 Marcelo Ricardo Leitner
2015-03-19 19:04 ` David Miller
2015-03-19 19:16 ` Marcelo Ricardo Leitner
2015-03-19 19:47 ` [PATCH v2] " Marcelo Ricardo Leitner
2015-03-19 20:06 ` David Miller
2015-03-20 2:09 ` Ying Xue [this message]
2015-03-20 12:35 ` Marcelo
2015-03-23 3:00 ` Ying Xue
2015-03-23 11:33 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B8156.3020400@windriver.com \
--to=ying.xue@windriver.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.