From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Lagerwall Subject: Re: [PATCH] tools/libxl: Fix the errno Date: Fri, 20 Mar 2015 08:25:44 +0000 Message-ID: <550BD988.7090209@citrix.com> References: <550BD79A.7020603@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <550BD79A.7020603@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wen Congyang , Andrew Cooper Cc: Ian Campbell , xen devel List-Id: xen-devel@lists.xenproject.org On 03/20/2015 08:17 AM, Wen Congyang wrote: > After commit 6d896e13, we should pass -errno on read failure. > > Signed-off-by: Wen Congyang > --- > tools/libxl/libxl_aoutils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxl/libxl_aoutils.c b/tools/libxl/libxl_aoutils.c > index 0d4c8af..b93f0e4 100644 > --- a/tools/libxl/libxl_aoutils.c > +++ b/tools/libxl/libxl_aoutils.c > @@ -262,7 +262,7 @@ static void datacopier_readable(libxl__egc *egc, libxl__ev_fd *ev, > assert(ferror(dc->log)); > assert(errno); > LOGE(ERROR, "error logging %s", dc->copywhat); > - datacopier_callback(egc, dc, 0, errno); > + datacopier_callback(egc, dc, 0, -errno); > return; > } > } > Acked-by: Ross Lagerwall -- Ross Lagerwall