diff for duplicates of <550C0459.5040204@suse.de> diff --git a/a/1.txt b/N1/1.txt index 59d7ec1..b71cdb3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -64,7 +64,7 @@ On 20.03.15 10:39, Paul Mackerras wrote: > + /* On POWER8 for IPIs to threads in the same core, use msgsnd */ > + if (cpu_has_feature(CPU_FTR_ARCH_207S)) { > + preempt_disable(); -> + if ((cpu & ~7) = (smp_processor_id() & ~7)) { +> + if ((cpu & ~7) == (smp_processor_id() & ~7)) { > + unsigned long msg = PPC_DBELL_TYPE(PPC_DBELL_SERVER); > + msg |= cpu & 7; > + smp_mb(); @@ -146,7 +146,7 @@ On 20.03.15 10:39, Paul Mackerras wrote: > > + /* On POWER8 for IPIs to threads in the same core, use msgsnd */ > + if (cpu_has_feature(CPU_FTR_ARCH_207S) && -> + (cpu & ~7) = (raw_smp_processor_id() & ~7)) { +> + (cpu & ~7) == (raw_smp_processor_id() & ~7)) { Can we somehow encapsulate the secret knowledge that 8 threads mean one core? diff --git a/a/content_digest b/N1/content_digest index 46387e5..5ecbeed 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01426844400-12017-21-git-send-email-paulus@samba.org\0" "From\0Alexander Graf <agraf@suse.de>\0" "Subject\0Re: [PATCH 20/23] KVM: PPC: Book3S HV: Use msgsnd for signalling threads on POWER8\0" - "Date\0Fri, 20 Mar 2015 11:28:25 +0000\0" + "Date\0Fri, 20 Mar 2015 12:28:25 +0100\0" "To\0Paul Mackerras <paulus@samba.org>" kvm-ppc@vger.kernel.org " kvm@vger.kernel.org\0" @@ -74,7 +74,7 @@ "> +\t/* On POWER8 for IPIs to threads in the same core, use msgsnd */\n" "> +\tif (cpu_has_feature(CPU_FTR_ARCH_207S)) {\n" "> +\t\tpreempt_disable();\n" - "> +\t\tif ((cpu & ~7) = (smp_processor_id() & ~7)) {\n" + "> +\t\tif ((cpu & ~7) == (smp_processor_id() & ~7)) {\n" "> +\t\t\tunsigned long msg = PPC_DBELL_TYPE(PPC_DBELL_SERVER);\n" "> +\t\t\tmsg |= cpu & 7;\n" "> +\t\t\tsmp_mb();\n" @@ -156,7 +156,7 @@ "> \n" "> +\t/* On POWER8 for IPIs to threads in the same core, use msgsnd */\n" "> +\tif (cpu_has_feature(CPU_FTR_ARCH_207S) &&\n" - "> +\t (cpu & ~7) = (raw_smp_processor_id() & ~7)) {\n" + "> +\t (cpu & ~7) == (raw_smp_processor_id() & ~7)) {\n" "\n" "Can we somehow encapsulate the secret knowledge that 8 threads mean one\n" "core?\n" @@ -164,4 +164,4 @@ "\n" Alex -25db4ebf7cc6c0d730a9476781c828913ceb8d985911e5babece484cbd862fa7 +2bda6870a962bdda184e6bddb1c239c0a524009becf92499f836e0a077119d1c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.