All of lore.kernel.org
 help / color / mirror / Atom feed
From: Varka Bhadram <varkabhadram@gmail.com>
To: Lad Prabhakar <prabhakar.csengg@gmail.com>,
	LMML <linux-media@vger.kernel.org>,
	devicetree@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor
Date: Fri, 20 Mar 2015 17:35:48 +0530	[thread overview]
Message-ID: <550C0D1C.1070200@gmail.com> (raw)
In-Reply-To: <1426852133-14539-1-git-send-email-prabhakar.csengg@gmail.com>

On 03/20/2015 05:18 PM, Lad Prabhakar wrote:

> From: Benoit Parrot <bparrot@ti.com>
>
> this patch adds support for omnivision's ov2659
> sensor, the driver supports following features:
> 1: Asynchronous probing
> 2: DT support
> 3: Media controller support
>
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>   Changes for v8:
>   --------------
>   a. Now setting the link_frequency control in set_fmt
>      callback instead of implementing g_volatile_ctrl()
>      for it and setting it there.
>
>   v7: https://patchwork.kernel.org/patch/6034651/
>   v6: https://patchwork.kernel.org/patch/6012751/
>   v5: https://patchwork.kernel.org/patch/6000161/
>   v4: https://patchwork.kernel.org/patch/5961661/
>   v3: https://patchwork.kernel.org/patch/5959401/
>   v2: https://patchwork.kernel.org/patch/5859801/
>   v1: https://patchwork.linuxtv.org/patch/27919/
>
>   .../devicetree/bindings/media/i2c/ov2659.txt       |   38 +
>   MAINTAINERS                                        |   10 +
>   drivers/media/i2c/Kconfig                          |   11 +
>   drivers/media/i2c/Makefile                         |    1 +
>   drivers/media/i2c/ov2659.c                         | 1528 ++++++++++++++++++++
>   include/media/ov2659.h                             |   33 +
>   6 files changed, 1621 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2659.txt
>   create mode 100644 drivers/media/i2c/ov2659.c
>   create mode 100644 include/media/ov2659.h
>
(...)

> +static struct ov2659_platform_data *
> +ov2659_get_pdata(struct i2c_client *client)
> +{
> +	struct ov2659_platform_data *pdata;
> +	struct device_node *endpoint;
> +	int ret;
> +
> +	if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node) {
> +		dev_err(&client->dev, "ov2659_get_pdata: DT Node found\n");

ov2659_get_pdata: DT Node *not* found...?

-- 
Varka Bhadram

  reply	other threads:[~2015-03-20 12:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 11:48 [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor Lad Prabhakar
2015-03-20 12:05 ` Varka Bhadram [this message]
2015-03-20 12:10   ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550C0D1C.1070200@gmail.com \
    --to=varkabhadram@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.