All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
To: Greg Knight <g.knight-+7FPL3kuI1+B+jHODAdFcQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Patch to parameterize DMA_MIN_BYTES for omap2-mcspi
Date: Fri, 20 Mar 2015 14:58:33 +0200	[thread overview]
Message-ID: <550C1979.5030208@ti.com> (raw)
In-Reply-To: <1426786080.13824.23.camel@symus-gk-mint>

On 03/19/2015 07:28 PM, Greg Knight wrote:
> Changing DMA_MIN_BYTES to, say, "dma_min_time_ms" sounds reasonable to
> me. I don't know how to compute it completely accurately as some SPI
> implementations I've seen seem to like to inject little delays between
> bytes for some reason, but a reasonable enough estimate should just be
> spi_transfer_time_ms = (bits * 1000) / spi_clock_speed.
> 
> I would like to have the ability to configure it without a kernel
> recompile, though. Would a kernel param (module_param) be acceptable for
> this application?

Or sysfs interface as Mark suggested? But module_param should work as well.

> You don't happen to know the WL12xx SPI clock speed off the top of your
> head, do you?

In case of n900 it is 48000000 (board-rx51-peripherals.c). It is using 32bit
words over SPI.

Based on this and your experience I guess it is possible to come up with a
formula which satisfy both.

> Regards,
> Greg
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
To: Greg Knight <g.knight-+7FPL3kuI1+B+jHODAdFcQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Patch to parameterize DMA_MIN_BYTES for omap2-mcspi
Date: Fri, 20 Mar 2015 14:58:33 +0200	[thread overview]
Message-ID: <550C1979.5030208@ti.com> (raw)
In-Reply-To: <1426786080.13824.23.camel@symus-gk-mint>

On 03/19/2015 07:28 PM, Greg Knight wrote:
> Changing DMA_MIN_BYTES to, say, "dma_min_time_ms" sounds reasonable to
> me. I don't know how to compute it completely accurately as some SPI
> implementations I've seen seem to like to inject little delays between
> bytes for some reason, but a reasonable enough estimate should just be
> spi_transfer_time_ms = (bits * 1000) / spi_clock_speed.
> 
> I would like to have the ability to configure it without a kernel
> recompile, though. Would a kernel param (module_param) be acceptable for
> this application?

Or sysfs interface as Mark suggested? But module_param should work as well.

> You don't happen to know the WL12xx SPI clock speed off the top of your
> head, do you?

In case of n900 it is 48000000 (board-rx51-peripherals.c). It is using 32bit
words over SPI.

Based on this and your experience I guess it is possible to come up with a
formula which satisfy both.

> Regards,
> Greg
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-03-20 12:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19  5:05 Patch to parameterize DMA_MIN_BYTES for omap2-mcspi Greg Knight
2015-03-19  9:47 ` Mark Brown
2015-03-19 12:34 ` Peter Ujfalusi
2015-03-19 12:34   ` Peter Ujfalusi
2015-03-19 13:16   ` Greg Knight
     [not found]     ` <CAAQQ3un3k-0nY8xaOXKbmCznOk69ZEhbWLd5ZZV1_=rQLOyspg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-19 14:03       ` Mark Brown
2015-03-19 16:23       ` Peter Ujfalusi
2015-03-19 16:23         ` Peter Ujfalusi
     [not found]         ` <550AF7F6.7080200-l0cyMroinI0@public.gmane.org>
2015-03-19 17:28           ` Greg Knight
2015-03-19 18:51             ` Mark Brown
2015-03-20 13:10               ` Peter Ujfalusi
2015-03-20 13:10                 ` Peter Ujfalusi
     [not found]                 ` <550C1C2C.5080204-l0cyMroinI0@public.gmane.org>
2015-03-22 16:31                   ` Mark Brown
2015-03-20 12:58             ` Peter Ujfalusi [this message]
2015-03-20 12:58               ` Peter Ujfalusi
2016-05-31  5:03               ` Anton Habegger
  -- strict thread matches above, loose matches on Subject: below --
2015-03-18 19:37 Greg Knight
2015-03-18 20:31 ` Tony Lindgren
     [not found]   ` <CAAQQ3umQu=Zh6MC=uXTxzbXGgm48KY6KQTPo4=f=0cVy+FFv-Q@mail.gmail.com>
2015-03-18 22:01     ` Tony Lindgren
2015-03-18 22:04   ` Greg Knight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550C1979.5030208@ti.com \
    --to=peter.ujfalusi-l0cymroini0@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=g.knight-+7FPL3kuI1+B+jHODAdFcQ@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.