Re: [PATCH 2/5] media: New flag V4L2_CTRL_FLAG_EXECUTE_ON_WRITE

[Hans Verkuil <hverkuil@xs4all.nl>]

On 03/19/2015 04:21 PM, Ricardo Ribalda Delgado wrote:
> Create a new flag that represent controls that represent controls that

Double 'that represent controls' :-)

> its value needs to be passed to the driver even if it has not changed.
> 
> They typically represent actions, like triggering a flash or clearing an
> error flag.

I would add something like:

"So writing to such a control means some action is executed."

This ties in a bit better with the name of the flag.

	Hans

> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  include/uapi/linux/videodev2.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index fbdc360..1e33e10 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -1456,6 +1456,7 @@ struct v4l2_querymenu {
>  #define V4L2_CTRL_FLAG_WRITE_ONLY 	0x0040
>  #define V4L2_CTRL_FLAG_VOLATILE		0x0080
>  #define V4L2_CTRL_FLAG_HAS_PAYLOAD	0x0100
> +#define V4L2_CTRL_FLAG_EXECUTE_ON_WRITE	0x0200
>  
>  /*  Query flags, to be ORed with the control ID */
>  #define V4L2_CTRL_FLAG_NEXT_CTRL	0x80000000
>