From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH v2 03/22] xen/arm: Add bitmap_find_next_zero_area helper function Date: Fri, 20 Mar 2015 13:35:45 +0000 Message-ID: <550C2231.2070106@linaro.org> References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> <1426775889-29442-4-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426775889-29442-4-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hi Vijay, On 19/03/2015 14:37, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > bitmap_find_next_zero_area helper function will be used > by physical ITS driver imported from linux > > Signed-off-by: Vijaya Kumar K > --- > xen/arch/arm/arm64/lib/find_next_bit.c | 39 ++++++++++++++++++++++++++++++++ The code of bitmap_find_next_zero_area is generic, why didn't you implement it in xen/common/bitmap.c? FWIW, the Linux implementation is generic... Regards, -- Julien Grall