From: Martin Kepplinger <martink@posteo.de>
To: Varka Bhadram <varkabhadram@gmail.com>,
mark.rutland@arm.com, robh+dt@kernel.org, Pawel.Moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
dmitry.torokhov@gmail.com, alexander.stein@systec-electronic.com
Cc: hadess@hadess.net, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, linux-api@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
Martin Kepplinger <martin.kepplinger@theobroma-systems.com>,
Christoph Muellner <christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH v4] add support for Freescale's MMA8653FC 10 bit accelerometer
Date: Fri, 20 Mar 2015 14:43:03 +0100 [thread overview]
Message-ID: <550C23E7.500@posteo.de> (raw)
In-Reply-To: <550C0502.7090507@gmail.com>
Am 2015-03-20 um 12:31 schrieb Varka Bhadram:
> On 03/20/2015 04:50 PM, Martin Kepplinger wrote:
>> From: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
>>
( ...)
>> + return 0;
>> +
>> + err_free_irq:
>> + if (mma->irq)
>> + free_irq(mma->irq, mma);
>> + err_free_mem:
>> + kfree(mma);
>
> If we use devm_* API's above steps are not required
>
>> + err_out:
>> + return err;
>> +}
>> +
>> +static int mma8653fc_remove(struct i2c_client *client)
>> +{
>> + struct mma8653fc *mma = i2c_get_clientdata(client);
>> +
>> + free_irq(mma->irq, mma);
>> + dev_dbg(&client->dev, "unregistered accelerometer\n");
>> + kfree(mma);
>
> same as above..
>
thanks!
prev parent reply other threads:[~2015-03-20 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 11:20 [PATCH v4] add support for Freescale's MMA8653FC 10 bit accelerometer Martin Kepplinger
2015-03-20 11:31 ` Varka Bhadram
2015-03-20 13:43 ` Martin Kepplinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C23E7.500@posteo.de \
--to=martink@posteo.de \
--cc=Pawel.Moll@arm.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.stein@systec-electronic.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-api@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.kepplinger@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.