From mboxrd@z Thu Jan 1 00:00:00 1970
From: daniel.lezcano@linaro.org (Daniel Lezcano)
Date: Fri, 20 Mar 2015 15:04:28 +0100
Subject: [PATCH v3 0/5] clocksource: sun5i: Support parent clock rate
changes
In-Reply-To: <20150319225344.GF4255@lukather>
References: <1425550856-12928-1-git-send-email-maxime.ripard@free-electrons.com>
<20150319225344.GF4255@lukather>
Message-ID: <550C28EC.2040800@linaro.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org
On 03/19/2015 11:53 PM, Maxime Ripard wrote:
> Hi Daniel,
>
> On Thu, Mar 05, 2015 at 11:20:51AM +0100, Maxime Ripard wrote:
>> Hi,
>>
>> The Allwinner HS timers have the AHB clock as their parent
>> clock. Since this clock is shared with other devices, we could very
>> well have another driver requesting a rate change of that clock,
>> making our timer change frequency at the same time.
>>
>> This is especially true on the A31, where the DMA controller needs to
>> do such a rate change, making the HS timer unreliable at the time on
>> the A31.
>>
>> This serie makes some cleanups and implements clock notifiers to be
>> able to reflect such rate changes and make sure that the timer is
>> always working.
>>
>> Maxime
>>
>> Changes from v2:
>> - Rebased on top of v4.0-rc1
>> - Removed the local_irq_save/restore around clockevents_update_freq
>>
>> Changes from v1:
>> - Changed the interrupt name to its previous value
>>
>> Maxime Ripard (5):
>> clocksource: sun5i: Switch to request_irq
>> clocksource: sun5i: Use of_io_request_and_map
>> clocksource: sun5i: Remove sched_clock
>> clocksource: sun5i: Refactor the current code
>> clocksource: sun5i: Add clock notifiers
>
> Have these patches been merged?
>
> If not, it woulde be great if the third one ("clocksource: sun5i:
> Remove sched_clock") was merged for 4.0.
>
> The sched_clock we use on some system is this timer's, and since we
> started using cpufreq, the cpu clock (that is one of the timer's clock
> indirect parent) now changes, along with the actual sched_clock rate.
>
> We can safely remove the sched_clock on those systems, since we have
> other reliable sched_clock in the system.
Ok, I applied the patch for v4.0-rc5 but I had to fix a conflict and
change the changelog.
Mind to test it works ?
git.linaro.org/people/daniel.lezcano/linux.git clockevents/v4.0-rc4
Thanks
-- Daniel
--
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook |
Twitter |
Blog
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1751740AbbCTOEd (ORCPT );
Fri, 20 Mar 2015 10:04:33 -0400
Received: from mail-we0-f170.google.com ([74.125.82.170]:35294 "EHLO
mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1750764AbbCTOEc (ORCPT
);
Fri, 20 Mar 2015 10:04:32 -0400
Message-ID: <550C28EC.2040800@linaro.org>
Date: Fri, 20 Mar 2015 15:04:28 +0100
From: Daniel Lezcano
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Maxime Ripard ,
Thomas Gleixner
CC: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] clocksource: sun5i: Support parent clock rate
changes
References: <1425550856-12928-1-git-send-email-maxime.ripard@free-electrons.com> <20150319225344.GF4255@lukather>
In-Reply-To: <20150319225344.GF4255@lukather>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID:
X-Mailing-List: linux-kernel@vger.kernel.org
On 03/19/2015 11:53 PM, Maxime Ripard wrote:
> Hi Daniel,
>
> On Thu, Mar 05, 2015 at 11:20:51AM +0100, Maxime Ripard wrote:
>> Hi,
>>
>> The Allwinner HS timers have the AHB clock as their parent
>> clock. Since this clock is shared with other devices, we could very
>> well have another driver requesting a rate change of that clock,
>> making our timer change frequency at the same time.
>>
>> This is especially true on the A31, where the DMA controller needs to
>> do such a rate change, making the HS timer unreliable at the time on
>> the A31.
>>
>> This serie makes some cleanups and implements clock notifiers to be
>> able to reflect such rate changes and make sure that the timer is
>> always working.
>>
>> Maxime
>>
>> Changes from v2:
>> - Rebased on top of v4.0-rc1
>> - Removed the local_irq_save/restore around clockevents_update_freq
>>
>> Changes from v1:
>> - Changed the interrupt name to its previous value
>>
>> Maxime Ripard (5):
>> clocksource: sun5i: Switch to request_irq
>> clocksource: sun5i: Use of_io_request_and_map
>> clocksource: sun5i: Remove sched_clock
>> clocksource: sun5i: Refactor the current code
>> clocksource: sun5i: Add clock notifiers
>
> Have these patches been merged?
>
> If not, it woulde be great if the third one ("clocksource: sun5i:
> Remove sched_clock") was merged for 4.0.
>
> The sched_clock we use on some system is this timer's, and since we
> started using cpufreq, the cpu clock (that is one of the timer's clock
> indirect parent) now changes, along with the actual sched_clock rate.
>
> We can safely remove the sched_clock on those systems, since we have
> other reliable sched_clock in the system.
Ok, I applied the patch for v4.0-rc5 but I had to fix a conflict and
change the changelog.
Mind to test it works ?
git.linaro.org/people/daniel.lezcano/linux.git clockevents/v4.0-rc4
Thanks
-- Daniel
--
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook |
Twitter |
Blog