From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: elena.ufimtseva@oracle.com, wei.liu2@citrix.com,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
dario.faggioli@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org
Subject: Re: [PATCH v5 6/8] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc
Date: Fri, 20 Mar 2015 10:24:34 -0400 [thread overview]
Message-ID: <550C2DA2.3040309@oracle.com> (raw)
In-Reply-To: <1426859677.21742.192.camel@citrix.com>
On 03/20/2015 09:54 AM, Ian Campbell wrote:
> On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote:
>> + if (cputopo) {
>> + if ((ret = xc_hypercall_bounce_pre(xch, cputopo)))
> I think this guy will tolerate a NULL here (and on post), so I
> think/hope you can get away without this conditional stuff. Can you give
> it a go please.
I'll see if this works. (I can't mentally unwrap all these macros, I'll
need to test it. Or at least run it through pre-processor)
-boris
>
> The rest looked ok.
>
>
next prev parent reply other threads:[~2015-03-20 14:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 21:53 [PATCH v5 0/8] Display IO topology when PXM data is available (plus some cleanup) Boris Ostrovsky
2015-03-19 21:53 ` [PATCH v5 1/8] numa: __node_distance() should return u8 Boris Ostrovsky
2015-03-20 14:25 ` Konrad Rzeszutek Wilk
2015-03-19 21:53 ` [PATCH v5 2/8] pci: Stash device's PXM information in struct pci_dev Boris Ostrovsky
2015-03-20 14:01 ` Konrad Rzeszutek Wilk
2015-03-19 21:53 ` [PATCH v5 3/8] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient Boris Ostrovsky
2015-03-20 13:25 ` Ian Campbell
2015-03-20 14:00 ` Boris Ostrovsky
2015-03-20 14:10 ` Ian Campbell
2015-03-25 16:13 ` Andrew Cooper
2015-03-19 21:54 ` [PATCH v5 4/8] sysctl: Make XEN_SYSCTL_numainfo " Boris Ostrovsky
2015-03-20 13:26 ` Ian Campbell
2015-03-20 16:15 ` Jan Beulich
2015-03-19 21:54 ` [PATCH v5 5/8] sysctl: Add sysctl interface for querying PCI topology Boris Ostrovsky
2015-03-20 14:21 ` Konrad Rzeszutek Wilk
2015-03-20 16:26 ` Jan Beulich
2015-03-20 20:01 ` Boris Ostrovsky
2015-03-23 8:15 ` Jan Beulich
2015-03-23 13:58 ` Boris Ostrovsky
2015-03-19 21:54 ` [PATCH v5 6/8] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc Boris Ostrovsky
2015-03-20 13:54 ` Ian Campbell
2015-03-20 14:24 ` Boris Ostrovsky [this message]
2015-03-20 14:30 ` Ian Campbell
2015-03-19 21:54 ` [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s " Boris Ostrovsky
2015-03-20 13:49 ` Konrad Rzeszutek Wilk
2015-03-20 14:10 ` Boris Ostrovsky
2015-03-20 14:21 ` Ian Campbell
2015-03-20 13:56 ` Ian Campbell
2015-03-20 14:31 ` Boris Ostrovsky
2015-03-20 14:46 ` Ian Campbell
2015-03-20 14:59 ` Boris Ostrovsky
2015-03-19 21:54 ` [PATCH v5 8/8] libxl: Add interface for querying hypervisor about PCI topology Boris Ostrovsky
2015-03-23 12:42 ` [PATCH v5 0/8] Display IO topology when PXM data is available (plus some cleanup) Julien Grall
2015-03-23 13:47 ` Boris Ostrovsky
2015-03-23 14:30 ` George Dunlap
2015-03-23 14:33 ` Boris Ostrovsky
2015-03-23 14:42 ` Ian Campbell
2015-03-23 15:26 ` Julien Grall
2015-03-23 15:27 ` Jan Beulich
2015-03-23 15:33 ` Boris Ostrovsky
2015-03-23 15:46 ` Jan Beulich
2015-03-23 14:30 ` Jan Beulich
2015-03-23 14:38 ` George Dunlap
2015-03-23 15:17 ` Ian Campbell
2015-03-23 15:21 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C2DA2.3040309@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.