All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/libxl: Fix the errno
Date: Fri, 20 Mar 2015 16:02:49 +0000	[thread overview]
Message-ID: <550C44A9.9030908@citrix.com> (raw)
In-Reply-To: <1426850139.21742.136.camel@citrix.com>

On 03/20/2015 11:15 AM, Ian Campbell wrote:
> On Fri, 2015-03-20 at 11:03 +0000, Ian Campbell wrote:
>> Do the new callers actually need the number of bytes read/written or was
>> this just something which seemed like a good idea since it was in hand?
>>
>> If it isn't needed
>
> In fact, irrespective of the needs of the future callers lets go back to
> the old semantics of errnoval for now, since it should be a quick and
> easy patch, I think.
>
> Then if it is actually needed we can sort out the propagation of the
> number of bytes read in a new patch as part of that series.
>

Some indication of whether the number of bytes requested were actually 
read is needed. Consider reading a struct of size X off the wire. The 
caller needs to know whether the number of bytes requested was actually 
was read or if they got an early EOF.

But in the meantime I will send a patch to fix restore the original 
behavior for errnoval.

--
Ross Lagerwall

  reply	other threads:[~2015-03-20 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20  8:17 [PATCH] tools/libxl: Fix the errno Wen Congyang
2015-03-20  8:25 ` Ross Lagerwall
2015-03-20  8:39   ` Wen Congyang
2015-03-20 11:03 ` Ian Campbell
2015-03-20 11:15   ` Ian Campbell
2015-03-20 16:02     ` Ross Lagerwall [this message]
2015-03-20 16:09       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550C44A9.9030908@citrix.com \
    --to=ross.lagerwall@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.