From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH v2 00/22] xen/arm: Add ITS support Date: Fri, 20 Mar 2015 16:23:48 +0000 Message-ID: <550C4994.9020007@linaro.org> References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hi Vijay, On 19/03/2015 14:37, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > Add ITS support for arm. Following major features > are supported > - GICv3 ITS support for arm64 platform > - Supports multi ITS node > - LPI descriptors are allocated on-demand > - Only ITS Dom0 is supported > > Tested with single ITS node. Some though about the whole design: Your vGIC ITS driver does too much things. In general a virtual driver should only emulate the hardware for the domain and forward the request to the physical driver. Your series adds device management (create/free) in the vITS, which is wrong. How do you check if the domain can use the device? Currently, you allow any domain to use any device. That would bring a big mess with guest using passthrough. Also, does the guess will always pass the correct devid? If not how do you plan to handle it? Regards, -- Julien Grall