All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Akash Verma <akashv@google.com>, fio <fio@vger.kernel.org>
Cc: Brian Fulton <bfulton@google.com>
Subject: Re: Buggy behavior with zone, random IOs since specific commit
Date: Fri, 20 Mar 2015 10:37:02 -0600	[thread overview]
Message-ID: <550C4CAE.7070905@kernel.dk> (raw)
In-Reply-To: <CAFFT=U=vjqCZDoP5M31ifDWaLcG7LEhjgYHKzhdJ6mc6gDO0Sg@mail.gmail.com>

On 03/18/2015 10:24 PM, Akash Verma wrote:
> This commit seems to have broken the behavior of random IOs with zone options:
>
> 4c8be5b1569f0aca8c7769803e57b79280d1f668
>
> Using this example job file:
> [zoned_out]
> rw=read
> bs=1k
> offset=510k
> ioengine=sync
> zonesize=1k
> zonerange=512k
> zoneskip=512k
> write_iolog=ios_meec.iolog
> filename=10MFile
>
> where 10M file was created as:
> dd if=/dev/zero of=./10MFile bs=1M count=10
>
> Prior to the above commit, FIO does one read per zone, and the job
> exits after the last zone. This is as expected.
>
> Post the above commit, FIO loops back to the first zone and may or may
> not succeed in finding a valid offset to seek to. With offset=510k, it
> fails on the first loop-back. With offset=100k, it fails on the
> second; with no offset, it did about a 100 loops. With --debug=random,
> I see messages like:
>
> file     1885  get file 10MFile, ref=1
> random   1885  off rand 1823528783
> io       1885  get_next_offset: offset 18446744073708827648 >= size 10485760
> io       1885  io_u 0x8c8e80, failed getting offset
>
> There should be no loop-back happening at all unless this is specified
> as desired (e.g. using runtime and time_based, or io_limit, or
> number_ios).

It might be more work, but yes, that I think is a good start. Care to 
send a patch to stop looping unless we're forced to? At least that will 
fix the case of buggy looping.

-- 
Jens Axboe



  reply	other threads:[~2015-03-20 16:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19  4:24 Buggy behavior with zone, random IOs since specific commit Akash Verma
2015-03-20 16:37 ` Jens Axboe [this message]
2015-03-28  1:25   ` Akash Verma
2015-03-28  1:26   ` Akash Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550C4CAE.7070905@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=akashv@google.com \
    --cc=bfulton@google.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.