From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH v2 10/22] xen/arm: Add helper function to get domain page Date: Fri, 20 Mar 2015 16:39:15 +0000 Message-ID: <550C4D33.8050203@linaro.org> References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> <1426775889-29442-11-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426775889-29442-11-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hello Vijay, On 19/03/2015 14:37, vijay.kilari@gmail.com wrote: > +struct page_info *get_page_from_paddr(struct domain *d, paddr_t paddr, > + unsigned long flags) > +{ > + struct p2m_domain *p2m = &d->arch.p2m; > + struct page_info *page = NULL; > + > + ASSERT(d == current->domain); > + > + spin_lock(&p2m->lock); > + > + if ( !mfn_valid(paddr >> PAGE_SHIFT) ) If I understand correctly this function is to get a page from an IPA, right? Firstly, this function is wrong because you assume IPA == MFN. This is not valid for guest and may not be for DOM0. Secondly, we already have a function which does this job (see get_page_from_gfn). Why can't you use it? Regards, -- Julien Grall