From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH v2 12/22] xen/arm: its: Update irq descriptor for LPIs support Date: Fri, 20 Mar 2015 16:44:20 +0000 Message-ID: <550C4E64.4040007@linaro.org> References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> <1426775889-29442-13-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426775889-29442-13-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hello Vijay, On 19/03/2015 14:37, vijay.kilari@gmail.com wrote: > diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h > index 435dfcd..f091739 100644 > --- a/xen/include/asm-arm/irq.h > +++ b/xen/include/asm-arm/irq.h > @@ -17,6 +17,8 @@ struct arch_pirq > struct arch_irq_desc { > int eoi_cpu; > unsigned int type; > + unsigned int virq; > + struct its_device *dev; > }; It seems you again miss my comment... As said on v1 this is not the solution. You add data for any IRQ (around 16K in Xen) just for handling LPIs. I provided a patch to handle virq != irq [1] and we should use it in order to diverge handling between LPIs and SPIs. If you are not happy with it, please see why. Regards, [1] https://patches.linaro.org/43012/ -- Julien Grall