From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ0yR-00078n-JX for qemu-devel@nongnu.org; Fri, 20 Mar 2015 13:44:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZ0yQ-0004eY-Q7 for qemu-devel@nongnu.org; Fri, 20 Mar 2015 13:44:43 -0400 Message-ID: <550C5C83.2040204@suse.de> Date: Fri, 20 Mar 2015 18:44:35 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1426811056-2202-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1426811056-2202-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 20.03.2015 um 01:24 schrieb John Snow: > Two issues were unearthed from ahci-test on ppc64: >=20 > (1) The ahci_populate_sglist function had endian issues, > which is only likely to impact PIO transfers for buffers > greater than one sector, and >=20 > (2) multiple-sector PIO which I attempted to repair in > 36334faf has been broken for years. ahci-test didn't catch > this because it used a pattern that was identical for each > sector. >=20 > So the pattern has been corrected and the underlying issue > fixed. >=20 > This should clear up the test failures (properly) for ppc64. >=20 > John Snow (4): > ide: fix cmd_write_pio when nsectors > 1 > ide: fix cmd_read_pio when nsectors > 1 > ahci: Fix sglist offset manipulation for BE machines > ahci-test: improve rw buffer patterns Confirming that it resolves the observed failure, Tested-by: Andreas F=E4rber Thanks for the quick fix, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)