From: Marc Zyngier <marc.zyngier@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] armv8/cache: Fix page table creation
Date: Fri, 20 Mar 2015 18:06:01 +0000 [thread overview]
Message-ID: <550C6189.2080900@arm.com> (raw)
In-Reply-To: <1426852073-10299-1-git-send-email-thierry.reding@gmail.com>
On 20/03/15 11:47, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> While generating the page tables, a running integer index is shifted by
> SECTION_SHIFT (29) and causes overflow for any integer bigger than 7.
> The page tables therefore alias to the same 8 sections and cause U-Boot
> to hang once the MMU is enabled.
>
> Fix this by making the index a 64-bit unsigned integer and so avoid the
> overflow.
>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/cpu/armv8/cache_v8.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c
> index c5ec5297cd39..254a629a3b8c 100644
> --- a/arch/arm/cpu/armv8/cache_v8.c
> +++ b/arch/arm/cpu/armv8/cache_v8.c
> @@ -25,9 +25,9 @@ void set_pgtable_section(u64 *page_table, u64 index, u64 section,
> /* to activate the MMU we need to set up virtual memory */
> static void mmu_setup(void)
> {
> - int i, j, el;
> bd_t *bd = gd->bd;
> - u64 *page_table = (u64 *)gd->arch.tlb_addr;
> + u64 *page_table = (u64 *)gd->arch.tlb_addr, i, j;
> + int el;
>
> /* Setup an identity-mapping for all spaces */
> for (i = 0; i < (PGTABLE_SIZE >> 3); i++) {
>
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-03-20 18:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 11:47 [U-Boot] [PATCH 1/6] armv8/cache: Fix page table creation Thierry Reding
2015-03-20 11:47 ` [U-Boot] [PATCH 2/6] armv8: Implement CONFIG_SYS_MALLOC_F_LEN support Thierry Reding
2015-03-24 14:47 ` FengHua
2015-03-20 11:47 ` [U-Boot] [PATCH 3/6] armv8/mmu: Clean up TCR programming Thierry Reding
2015-03-20 18:13 ` Marc Zyngier
2015-07-02 21:06 ` Albert ARIBAUD
2015-07-03 7:28 ` Marc Zyngier
2015-03-24 14:55 ` FengHua
2015-03-20 11:47 ` [U-Boot] [PATCH 4/6] armv8/mmu: Set bits marked RES1 in TCR Thierry Reding
2015-03-20 18:16 ` Marc Zyngier
2015-03-24 15:10 ` FengHua
2015-03-20 11:47 ` [U-Boot] [PATCH 5/6] armv8/gic: Fix GIC v2 initialization Thierry Reding
2015-03-20 18:03 ` Marc Zyngier
2015-03-20 11:47 ` [U-Boot] [PATCH 6/6] armv8: Allow SoCs to override the generic timer Thierry Reding
2015-03-20 18:18 ` Marc Zyngier
2015-03-24 14:59 ` FengHua
2015-03-20 18:06 ` Marc Zyngier [this message]
2015-03-24 14:52 ` [U-Boot] [PATCH 1/6] armv8/cache: Fix page table creation FengHua
2015-04-16 11:24 ` Albert ARIBAUD
2015-06-03 15:09 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C6189.2080900@arm.com \
--to=marc.zyngier@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.