Re: [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

[Max Reitz <mreitz@redhat.com>]

On 2015-03-20 at 10:33, Alberto Garcia wrote:
> There are several error messages that identify a BlockDriverState by
> its device name. However those errors can be produced in nodes that
> don't have a device name associated.
>
> In those cases we should use bdrv_get_device_or_node_name() to fall
> back to the node name and produce a more meaningful message. The
> messages are also updated to use the more generic term 'node' instead
> of 'device'.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   block.c                   | 24 ++++++++++++------------
>   block/qcow.c              |  8 ++++----
>   block/qcow2.c             |  2 +-
>   block/qed.c               |  2 +-
>   block/snapshot.c          | 12 ++++++------
>   block/vdi.c               |  6 +++---
>   block/vhdx.c              |  6 +++---
>   block/vmdk.c              |  8 ++++----
>   block/vpc.c               |  6 +++---
>   block/vvfat.c             |  7 ++++---
>   blockdev.c                |  9 +++++----
>   include/qapi/qmp/qerror.h |  6 ------
>   12 files changed, 46 insertions(+), 50 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>