From: Linhaifeng <haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH v3] lib/librte_vhost: update used->idx when allocation of mbuf fails
Date: Sat, 21 Mar 2015 16:41:11 +0800 [thread overview]
Message-ID: <550D2EA7.9080506@huawei.com> (raw)
In-Reply-To: <1426902420-21492-1-git-send-email-haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
cc changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
cc huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
On 2015/3/21 9:47, linhaifeng wrote:
> From: Linhaifeng <haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>
> When failed to malloc buffer from mempool we just update last_used_idx but
> not used->idx so after many times vhost thought have handle all packets
> but virtio_net thought vhost have not handle all packets and will not
> update avail->idx.
>
> Signed-off-by: Linhaifeng <haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
> lib/librte_vhost/vhost_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
> index 535c7a1..510ffe8 100644
> --- a/lib/librte_vhost/vhost_rxtx.c
> +++ b/lib/librte_vhost/vhost_rxtx.c
> @@ -609,7 +609,7 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint16_t queue_id,
> if (unlikely(m == NULL)) {
> RTE_LOG(ERR, VHOST_DATA,
> "Failed to allocate memory for mbuf.\n");
> - return entry_success;
> + break;
> }
> seg_offset = 0;
> seg_avail = m->buf_len - RTE_PKTMBUF_HEADROOM;
>
--
Regards,
Haifeng
next prev parent reply other threads:[~2015-03-21 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 1:47 [PATCH v3] lib/librte_vhost: update used->idx when allocation of mbuf fails linhaifeng
[not found] ` <1426902420-21492-1-git-send-email-haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-03-21 8:41 ` Linhaifeng [this message]
2015-03-22 12:08 ` Ouyang, Changchun
2015-03-24 7:14 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3F4851-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-24 7:46 ` Linhaifeng
2015-03-27 11:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550D2EA7.9080506@huawei.com \
--to=haifeng.lin-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.