From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] sunxi: musb: Return early on VBUS GPIO error instead of on a positive value
Date: Sat, 21 Mar 2015 13:56:29 +0100 [thread overview]
Message-ID: <550D6A7D.8060204@redhat.com> (raw)
In-Reply-To: <1426440467-4525-1-git-send-email-contact@paulk.fr>
Hi,
On 15-03-15 18:27, Paul Kocialkowski wrote:
> This allows printing the error message when VBUS is detected, as it would with
> AXP VBUS detect.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> drivers/usb/musb-new/sunxi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
> index 4d8c15a..90aaec6 100644
> --- a/drivers/usb/musb-new/sunxi.c
> +++ b/drivers/usb/musb-new/sunxi.c
> @@ -261,7 +261,7 @@ static int sunxi_musb_init(struct musb *musb)
> }
>
> err = gpio_get_value(vbus_det);
> - if (err) {
> + if (err < 0) {
> gpio_free(vbus_det);
> return -EIO;
> }
>
Good catch, thanks I've send a pull-req with this fix upstream,
please base your next patch-set on u-boot-sunxi/master, or
at least keep this patch as a base before doing the axp gpio
cleanups I asked for in my previous mail.
Regards,
Hans
prev parent reply other threads:[~2015-03-21 12:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 17:27 [U-Boot] [PATCH 1/4] sunxi: musb: Return early on VBUS GPIO error instead of on a positive value Paul Kocialkowski
2015-03-15 17:27 ` [U-Boot] [PATCH 2/4] sunxi: Avoid any assumption between musb gadget and host but fallback to host Paul Kocialkowski
2015-03-21 13:14 ` Hans de Goede
2015-03-22 10:54 ` Paul Kocialkowski
2015-03-15 17:27 ` [U-Boot] [PATCH 3/4] sunxi: common VBUS detection logic in usbc Paul Kocialkowski
2015-03-15 18:19 ` Marek Vasut
2015-03-15 21:54 ` Paul Kocialkowski
2015-03-15 23:31 ` Marek Vasut
2015-03-21 13:15 ` Hans de Goede
2015-03-15 17:27 ` [U-Boot] [PATCH 4/4] board: sunxi: USB download gadget cable detection Paul Kocialkowski
2015-03-21 12:56 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550D6A7D.8060204@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.