Re: Recovery after mkfs.ext4 on a ext4

[Killian De Volder <killian.de.volder@scarlet.be>]

On 23-06-14 19:31, Theodore Ts'o wrote:
>
> ...
> We do actually keep a linked list of these inode numbers so we can try
> to report a directory name so you know which file has been trashed.
> This happens in pass #2, so the inodes which are invalid are stored in
> pass #1 and only removed in pass #2.  
>
> So if you are seeing gazillions of bad inodes, that could very easily
> be what's going on.  If so, I can imagine having some mode that we
> enter after a hundred inodes where we just ask permission to blow away
> all of the corrupted inodes in pass #1, without waiting until we can
> give you a proper pathname.
> ...
>
>
> 						 - Ted
>
Been thinking, maybe I should rewrite this code to used linked-arrays ?
Linked lists are painfully slow on swap. (and cpu too because of all the cache misses)
Or are we doing a lot of inserts ?

Think it might be worth it ? Would take me a week to learn the code in e2fsck though...
Biggest fear I have is making a mistake in the code that causes silent bugs.

Kind regards, Killian