All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Priit Laes <plaes@plaes.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	Chaoming Li <chaoming_li@realsil.com.cn>,
	Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 0/4] rtlwifi: Use common functions for driver stats
Date: Sun, 22 Mar 2015 11:27:51 -0500	[thread overview]
Message-ID: <550EED87.8010008@lwfinger.net> (raw)
In-Reply-To: <1427031320-10913-1-git-send-email-plaes@plaes.org>

On 03/22/2015 08:35 AM, Priit Laes wrote:
> Hi all,
>
> This is a small fixup to unify make the drivers use common helper
> functions for driver statistics.
>
> There are no functional changes since the first posting, except dropping
> patches already applied and addressing the comments by Joe Perches.

Are there patches that are required before these work? Applying these four 
results in the following build errors:

drivers/net/wireless/rtlwifi/rtl8192de/trx.c: In function 
‘_rtl92de_query_rxphystatus’:
drivers/net/wireless/rtlwifi/rtl8192de/trx.c:132:3: error: implicit declaration 
of function ‘rtl_query_rxpwrpercentage’ [-Werror=implicit-function-declaration]
    pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
    ^
drivers/net/wireless/rtlwifi/rtl8192de/trx.c:192:4: error: implicit declaration 
of function ‘rtl_evm_db_to_percentage’ [-Werror=implicit-function-declaration]
     evm = rtl_evm_db_to_percentage(p_drvinfo->rxevm[i]);
     ^
drivers/net/wireless/rtlwifi/rtl8192de/trx.c:204:4: error: implicit declaration 
of function ‘rtl_signal_scale_mapping’ [-Werror=implicit-function-declaration]
     (u8)(rtl_signal_scale_mapping(pwdb_all));
     ^
cc1: some warnings being treated as errors
scripts/Makefile.build:258: recipe for target 
'drivers/net/wireless/rtlwifi/rtl8192de/trx.o' failed

I cannot find any patches that created common routines in rtlwifi.

Larry


  parent reply	other threads:[~2015-03-22 16:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 13:35 [PATCH v2 0/4] rtlwifi: Use common functions for driver stats Priit Laes
2015-03-22 13:35 ` Priit Laes
2015-03-22 13:35 ` [PATCH v2 1/4] rtlwifi: Use common rtl_evm_db_to_percentage Priit Laes
2015-03-22 13:35   ` Priit Laes
2015-03-22 13:35 ` [PATCH v2 2/4] rtlwifi: Use common rtl_signal_scale_mapping Priit Laes
2015-03-22 13:35 ` [PATCH v2 3/4] rtlwifi: Rename rtl_translate_todbm to rtl_signalpower_todbm Priit Laes
2015-03-22 13:35 ` [PATCH v2 4/4] rtlwifi: Use common rtl_query_rxpwrpercentage function Priit Laes
2015-03-22 16:27 ` Larry Finger [this message]
2015-03-22 17:05   ` [PATCH v2 0/4] rtlwifi: Use common functions for driver stats Priit Laes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550EED87.8010008@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=joe@perches.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=plaes@plaes.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.