From: Guenter Roeck <linux@roeck-us.net>
To: James Hogan <james.hogan@imgtec.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Cc: James Hogan <james@albanarts.com>,
Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
Naidu Tellapati <Naidu.Tellapati@imgtec.com>,
Jude Abraham <Jude.Abraham@imgtec.com>
Subject: Re: [PATCH 0/2] watchdog: imgpdc: Runtime fixes
Date: Sun, 22 Mar 2015 10:06:04 -0700 [thread overview]
Message-ID: <550EF67C.7050601@roeck-us.net> (raw)
In-Reply-To: <20150320205315.GB22574@jhogan-linux.le.imgtec.org>
On 03/20/2015 01:53 PM, James Hogan wrote:
> Hi,
>
> On Fri, Feb 20, 2015 at 11:45:43PM +0000, James Hogan wrote:
>> A couple of basic runtime fixes for the IMG PDC watchdog driver. These
>> were found by attempting to enable the driver for TZ1090 and running
>> under Meta QEMU. Note that QEMU doesn't emulate the actual watchdog
>> functionality beyond the soft reset register, so I cannot claim to have
>> tested the driver's watchdog timer functionality yet.
>>
>> James Hogan (2):
>> watchdog: imgpdc: Fix probe NULL pointer dereference
>> watchdog: imgpdc: Fix default heartbeat
>
> Thanks Guenter for the reviews.
>
> Any chance of these fixes getting merged in time for v4.0?
>
I agree that would be good. There is also 'watchdog: mtk_wdt:
signedness bug in mtk_wdt_start()' which should be in 4.0 as well.
Wim, if you are busy, want me to prepare and send a pull request to Linus ?
Thanks,
Guenter
next prev parent reply other threads:[~2015-03-22 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 23:45 [PATCH 0/2] watchdog: imgpdc: Runtime fixes James Hogan
2015-02-20 23:45 ` [PATCH 1/2] watchdog: imgpdc: Fix probe NULL pointer dereference James Hogan
2015-02-23 19:26 ` Guenter Roeck
2015-02-20 23:45 ` [PATCH 2/2] watchdog: imgpdc: Fix default heartbeat James Hogan
2015-02-23 19:27 ` Guenter Roeck
2015-03-20 20:53 ` [PATCH 0/2] watchdog: imgpdc: Runtime fixes James Hogan
2015-03-22 17:06 ` Guenter Roeck [this message]
2015-03-24 7:42 ` Wim Van Sebroeck
2015-03-24 8:19 ` Wim Van Sebroeck
2015-03-24 8:47 ` Naidu Tellapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550EF67C.7050601@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jude.Abraham@imgtec.com \
--cc=Naidu.Tellapati@imgtec.com \
--cc=ezequiel.garcia@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=james@albanarts.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.