From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v6 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() Date: Mon, 23 Mar 2015 09:08:41 +0800 Message-ID: <550F6799.1000301@huawei.com> References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-10-git-send-email-wangyijing@huawei.com> <550DFD13.9080505@amd.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <550DFD13.9080505@amd.com> Sender: linux-alpha-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Suravee Suthikulpanit , Bjorn Helgaas Cc: Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Liviu Dudau , Arnd Bergmann , Geert Uytterhoeven >> +struct pci_host_bridge *pci_create_host_bridge( >> + struct device *parent, u32 db, struct list_head *resources) >> +{ >> + int error; >> + int bus = PCI_BUSNUM(db); >> + int domain = PCI_DOMAIN(db); >> + struct pci_host_bridge *host; >> + struct resource_entry *window, *n; >> + >> + host = kzalloc(sizeof(*host), GFP_KERNEL); >> + if (!host) >> + return NULL; >> + >> + host->busnum = bus; >> + host->domain = domain; >> + /* If support CONFIG_PCI_DOMAINS_GENERIC, use >> + * pci_host_assign_domain_nr() to assign domain >> + * number instead PCI_DOMAIN(db). >> + */ >> + pci_host_assign_domain_nr(host); > > At this point, host->dev.parent has not been assigned. However, when calling pci_host_assign_domain_nr(host), it calls pci_assign_domain_nr(host->dev.parent), which uses parent->of_node directly w/o checking if parent is NULL. This ended up causing NULL pointer exception when I do the test. > > I think we need to moveo host->dev.parent = parent before calling pci_host_assign_domain_nr(host). Good catch! Hi Suravee, thanks for your test, I would assign host->dev.parent before pci_host_assign_domain_nr(). Thanks! Yijing. > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Mon, 23 Mar 2015 01:08:41 +0000 Subject: Re: [PATCH v6 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() Message-Id: <550F6799.1000301@huawei.com> List-Id: References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-10-git-send-email-wangyijing@huawei.com> <550DFD13.9080505@amd.com> In-Reply-To: <550DFD13.9080505@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Suravee Suthikulpanit , Bjorn Helgaas Cc: Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@vger.kernel.org, Liviu Dudau , Arnd Bergmann , Geert Uytterhoeven >> +struct pci_host_bridge *pci_create_host_bridge( >> + struct device *parent, u32 db, struct list_head *resources) >> +{ >> + int error; >> + int bus = PCI_BUSNUM(db); >> + int domain = PCI_DOMAIN(db); >> + struct pci_host_bridge *host; >> + struct resource_entry *window, *n; >> + >> + host = kzalloc(sizeof(*host), GFP_KERNEL); >> + if (!host) >> + return NULL; >> + >> + host->busnum = bus; >> + host->domain = domain; >> + /* If support CONFIG_PCI_DOMAINS_GENERIC, use >> + * pci_host_assign_domain_nr() to assign domain >> + * number instead PCI_DOMAIN(db). >> + */ >> + pci_host_assign_domain_nr(host); > > At this point, host->dev.parent has not been assigned. However, when calling pci_host_assign_domain_nr(host), it calls pci_assign_domain_nr(host->dev.parent), which uses parent->of_node directly w/o checking if parent is NULL. This ended up causing NULL pointer exception when I do the test. > > I think we need to moveo host->dev.parent = parent before calling pci_host_assign_domain_nr(host). Good catch! Hi Suravee, thanks for your test, I would assign host->dev.parent before pci_host_assign_domain_nr(). Thanks! Yijing. > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com ([119.145.14.66]:11027 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbbCWBJM (ORCPT ); Sun, 22 Mar 2015 21:09:12 -0400 Message-ID: <550F6799.1000301@huawei.com> Date: Mon, 23 Mar 2015 09:08:41 +0800 From: Yijing Wang MIME-Version: 1.0 To: Suravee Suthikulpanit , Bjorn Helgaas CC: Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven Subject: Re: [PATCH v6 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-10-git-send-email-wangyijing@huawei.com> <550DFD13.9080505@amd.com> In-Reply-To: <550DFD13.9080505@amd.com> Content-Type: text/plain; charset="windows-1252" Sender: linux-pci-owner@vger.kernel.org List-ID: >> +struct pci_host_bridge *pci_create_host_bridge( >> + struct device *parent, u32 db, struct list_head *resources) >> +{ >> + int error; >> + int bus = PCI_BUSNUM(db); >> + int domain = PCI_DOMAIN(db); >> + struct pci_host_bridge *host; >> + struct resource_entry *window, *n; >> + >> + host = kzalloc(sizeof(*host), GFP_KERNEL); >> + if (!host) >> + return NULL; >> + >> + host->busnum = bus; >> + host->domain = domain; >> + /* If support CONFIG_PCI_DOMAINS_GENERIC, use >> + * pci_host_assign_domain_nr() to assign domain >> + * number instead PCI_DOMAIN(db). >> + */ >> + pci_host_assign_domain_nr(host); > > At this point, host->dev.parent has not been assigned. However, when calling pci_host_assign_domain_nr(host), it calls pci_assign_domain_nr(host->dev.parent), which uses parent->of_node directly w/o checking if parent is NULL. This ended up causing NULL pointer exception when I do the test. > > I think we need to moveo host->dev.parent = parent before calling pci_host_assign_domain_nr(host). Good catch! Hi Suravee, thanks for your test, I would assign host->dev.parent before pci_host_assign_domain_nr(). Thanks! Yijing. > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Mon, 23 Mar 2015 09:08:41 +0800 Subject: [PATCH v6 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() In-Reply-To: <550DFD13.9080505@amd.com> References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-10-git-send-email-wangyijing@huawei.com> <550DFD13.9080505@amd.com> Message-ID: <550F6799.1000301@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org >> +struct pci_host_bridge *pci_create_host_bridge( >> + struct device *parent, u32 db, struct list_head *resources) >> +{ >> + int error; >> + int bus = PCI_BUSNUM(db); >> + int domain = PCI_DOMAIN(db); >> + struct pci_host_bridge *host; >> + struct resource_entry *window, *n; >> + >> + host = kzalloc(sizeof(*host), GFP_KERNEL); >> + if (!host) >> + return NULL; >> + >> + host->busnum = bus; >> + host->domain = domain; >> + /* If support CONFIG_PCI_DOMAINS_GENERIC, use >> + * pci_host_assign_domain_nr() to assign domain >> + * number instead PCI_DOMAIN(db). >> + */ >> + pci_host_assign_domain_nr(host); > > At this point, host->dev.parent has not been assigned. However, when calling pci_host_assign_domain_nr(host), it calls pci_assign_domain_nr(host->dev.parent), which uses parent->of_node directly w/o checking if parent is NULL. This ended up causing NULL pointer exception when I do the test. > > I think we need to moveo host->dev.parent = parent before calling pci_host_assign_domain_nr(host). Good catch! Hi Suravee, thanks for your test, I would assign host->dev.parent before pci_host_assign_domain_nr(). Thanks! Yijing. > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbbCWBJP (ORCPT ); Sun, 22 Mar 2015 21:09:15 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:11027 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbbCWBJM (ORCPT ); Sun, 22 Mar 2015 21:09:12 -0400 Message-ID: <550F6799.1000301@huawei.com> Date: Mon, 23 Mar 2015 09:08:41 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Suravee Suthikulpanit , Bjorn Helgaas CC: Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven Subject: Re: [PATCH v6 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-10-git-send-email-wangyijing@huawei.com> <550DFD13.9080505@amd.com> In-Reply-To: <550DFD13.9080505@amd.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.550F67AE.002C,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: a96453b2aa0958ba0220fa023b1b1ad3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> +struct pci_host_bridge *pci_create_host_bridge( >> + struct device *parent, u32 db, struct list_head *resources) >> +{ >> + int error; >> + int bus = PCI_BUSNUM(db); >> + int domain = PCI_DOMAIN(db); >> + struct pci_host_bridge *host; >> + struct resource_entry *window, *n; >> + >> + host = kzalloc(sizeof(*host), GFP_KERNEL); >> + if (!host) >> + return NULL; >> + >> + host->busnum = bus; >> + host->domain = domain; >> + /* If support CONFIG_PCI_DOMAINS_GENERIC, use >> + * pci_host_assign_domain_nr() to assign domain >> + * number instead PCI_DOMAIN(db). >> + */ >> + pci_host_assign_domain_nr(host); > > At this point, host->dev.parent has not been assigned. However, when calling pci_host_assign_domain_nr(host), it calls pci_assign_domain_nr(host->dev.parent), which uses parent->of_node directly w/o checking if parent is NULL. This ended up causing NULL pointer exception when I do the test. > > I think we need to moveo host->dev.parent = parent before calling pci_host_assign_domain_nr(host). Good catch! Hi Suravee, thanks for your test, I would assign host->dev.parent before pci_host_assign_domain_nr(). Thanks! Yijing. > > . > -- Thanks! Yijing