From: Yunlong Song <yunlong.song@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: <a.p.zijlstra@chello.nl>, <paulus@samba.org>, <mingo@redhat.com>,
<acme@kernel.org>, <linux-kernel@vger.kernel.org>,
<wangnan0@huawei.com>
Subject: Re: [PATCH] perf tools: Remove (null) value of "Sort order" for perf mem report
Date: Mon, 23 Mar 2015 11:58:33 +0800 [thread overview]
Message-ID: <550F8F69.2090005@huawei.com> (raw)
In-Reply-To: <20150323004433.GD2782@sejong>
On 2015/3/23 8:44, Namhyung Kim wrote:
> Hi Yunlong,
>
> On Thu, Mar 19, 2015 at 09:58:32PM +0800, Yunlong Song wrote:
>> When '--sort' is not set, 'perf mem report" will print a null pointer as
>> the output value of sort order, so fix it.
>>
>> Example:
>>
>> Before this patch:
>>
>> $ perf mem report
>> # To display the perf.data header info, please use --header/--header-only options.
>> #
>> # Samples: 18 of event 'cpu/mem-loads/pp'
>> # Total weight : 188
>> # Sort order : (null)
>> #
>> ...
>>
>> After this patch:
>>
>> $ perf mem report
>> # To display the perf.data header info, please use --header/--header-only options.
>> #
>> # Samples: 18 of event 'cpu/mem-loads/pp'
>> # Total weight : 188
>> #
>> ...
>
> I think it'd be better to show default sort order in this case.
>
>
Agree, I have changed that into a default sort order in PATCH v2, thanks.
--
Thanks,
Yunlong Song
prev parent reply other threads:[~2015-03-23 3:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 13:58 [PATCH] perf tools: Remove (null) value of "Sort order" for perf mem report Yunlong Song
2015-03-23 0:44 ` Namhyung Kim
2015-03-23 3:50 ` [PATCH v2] " Yunlong Song
2015-03-23 16:15 ` Arnaldo Carvalho de Melo
2015-03-23 23:38 ` Namhyung Kim
2015-03-24 2:03 ` Yunlong Song
2015-03-24 16:30 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-23 3:58 ` Yunlong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550F8F69.2090005@huawei.com \
--to=yunlong.song@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.