From: David Henningsson <david.henningsson@canonical.com>
To: Jie Yang <yang.jie@intel.com>, tiwai@suse.de, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, liam.r.girdwood@intel.com
Subject: Re: [PATCH v3 0/2] ALSA: jack: Refactoring for jack kctls
Date: Mon, 23 Mar 2015 10:18:19 +0100 [thread overview]
Message-ID: <550FDA5B.8020604@canonical.com> (raw)
In-Reply-To: <1426865953-1606-1-git-send-email-yang.jie@intel.com>
On 2015-03-20 16:39, Jie Yang wrote:
> Currently only hda will create kctls for hda jacks, for asoc, people
> may need create jack kctls in specific driver.
>
> Here we are introducing kctls for each jack, by creating kctls and add
> them to jack controls list (considering exist of combo jack). At the
> same time, we will report events for each control in the list.
>
> With this implement, we are no longer need hda jack specific kctls, so
> here also remove jack kctls for hda.
Hmm, I must have missed this. It's great that you try to implement kctl
jacks for ASoC, but your actual implementation seems to regress HDA,
unless I'm missing something.
In particular, the phantom jacks currently show up in the kctl jack
layer only, not in the /dev/input layer, and I prefer to keep it that
way in order not to pollute the /dev/input layer with phantom jacks.
But it looks like these will just disappear (?!) with your patch, but
I'm not entirely sure. Could you elaborate?
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
next prev parent reply other threads:[~2015-03-23 9:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 15:39 [PATCH v3 0/2] ALSA: jack: Refactoring for jack kctls Jie Yang
2015-03-20 15:39 ` [PATCH v3 1/2] ALSA: jack: create jack kcontrols for every jack input device Jie Yang
2015-03-20 16:17 ` Takashi Iwai
2015-03-21 2:22 ` Jie, Yang
2015-03-21 7:46 ` Takashi Iwai
2015-03-23 10:08 ` Tanu Kaskinen
2015-03-23 11:57 ` Takashi Iwai
2015-03-23 14:57 ` Mark Brown
2015-03-25 4:11 ` Jie, Yang
2015-03-25 5:27 ` Raymond Yau
2015-03-25 6:13 ` Takashi Iwai
2015-03-20 15:39 ` [PATCH v3 2/2] ALSA: hda - Remove jack kctls Jie Yang
2015-03-20 16:21 ` Takashi Iwai
2015-03-21 0:23 ` Jie, Yang
2015-03-23 9:18 ` David Henningsson [this message]
2015-03-23 15:00 ` [PATCH v3 0/2] ALSA: jack: Refactoring for " Mark Brown
2015-03-23 15:09 ` Takashi Iwai
2015-03-23 16:35 ` Mark Brown
2015-03-23 16:38 ` Takashi Iwai
2015-03-23 16:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550FDA5B.8020604@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@intel.com \
--cc=tiwai@suse.de \
--cc=yang.jie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.