From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 0/8] Display IO topology when PXM data is available (plus some cleanup) Date: Mon, 23 Mar 2015 12:42:14 +0000 Message-ID: <55100A26.7080801@linaro.org> References: <1426802044-19444-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1426802044-19444-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , andrew.cooper3@citrix.com, jbeulich@suse.com, keir@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com, dario.faggioli@citrix.com, elena.ufimtseva@oracle.com, xen-devel@lists.xen.orgJan Beulich List-Id: xen-devel@lists.xenproject.org Hi, On 19/03/15 21:53, Boris Ostrovsky wrote: > A few patches that add interface for querying hypervisor about device > topology and allow 'xl info -n' display this information if PXM object > is provided by ACPI. > = > This series also makes some optimizations and cleanup of current CPU > topology and NUMA sysctl queries. I saw that some of these patches was pushed upstream last week. It actually breaks compilation on ARM. While the first error is trivial to fix (it's a missing include xen/numa.h in xen/pci.h ). The second one is more difficult sysctl.c: In function =91do_sysctl=92: sysctl.c:349:42: error: =91BAD_APICID=92 undeclared (first use in this func= tion) if ( cputopo.core =3D=3D BAD_APICID ) ^ The value BAD_APICID doesn't have any meaning on ARM. Therefore the usage in common code looks wrong to me. I'm not sure what should be the testing value here given that cpu_to_core is not yet correctly implemented on ARM. It would be nice to at least build test it ARM/ARM64 before pushing patches which modify common code. Regards, -- = Julien Grall