From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2GL-00036b-2l for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:19:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya2GH-0003k4-1s for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:19:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34272 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2GG-0003ju-SD for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:19:20 -0400 Message-ID: <551012D7.4040900@suse.de> Date: Mon, 23 Mar 2015 14:19:19 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1427115352-4948-1-git-send-email-leon.alrae@imgtec.com> <55100EE5.9090404@suse.de> In-Reply-To: <55100EE5.9090404@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] linux-user: fix broken cpu_copy() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae , qemu-devel@nongnu.org Cc: riku.voipio@iki.fi, ehabkost@redhat.com, Alexander Graf Am 23.03.2015 um 14:02 schrieb Andreas F=E4rber: > Am 23.03.2015 um 13:55 schrieb Leon Alrae: >> New threads always point at the same env which is incorrect and usuall= y leads Please remember to break after 76 chars. (Look at `git log` output.) Andreas >> to a crash. >> >> Signed-off-by: Leon Alrae >> --- >> Hi, >> >> This patch fixes the bug introduced in: >> >> commit 2994fd96d986578a342f2342501b4ad30f6d0a85 >> Author: Eduardo Habkost >> >> cpu: Make cpu_init() return QOM CPUState object >> >> Regards, >> Leon >> --- >> linux-user/main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/linux-user/main.c b/linux-user/main.c >> index 6e446de..04668e8 100644 >> --- a/linux-user/main.c >> +++ b/linux-user/main.c >> @@ -3453,7 +3453,7 @@ CPUArchState *cpu_copy(CPUArchState *env) >> { >> CPUState *cpu =3D ENV_GET_CPU(env); >> CPUState *new_cpu =3D cpu_init(cpu_model); >> - CPUArchState *new_env =3D cpu->env_ptr; >> + CPUArchState *new_env =3D new_cpu->env_ptr; >> CPUBreakpoint *bp; >> CPUWatchpoint *wp; >> =20 >=20 > Clearly my fault and might explain some breakage in our OBS, >=20 > Reviewed-by: Andreas F=E4rber >=20 > Riku, are you queuing this (-rc1 tomorrow!) or should I take it for a > CPU pull? >=20 > Thanks, > Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)