From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"slaoub@gmail.com" <slaoub@gmail.com>,
"luto@amacapital.net" <luto@amacapital.net>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer
Date: Mon, 23 Mar 2015 09:20:00 -0500 [thread overview]
Message-ID: <55102110.4040106@amd.com> (raw)
In-Reply-To: <20150321061042.GA27221@pd.tnic>
On 3/21/2015 1:10 AM, Borislav Petkov wrote:
> On Fri, Mar 20, 2015 at 09:35:26PM -0500, Aravind Gopalakrishnan wrote:
>> Other function pointers in the mce code like unexpected_machine_check
>> and default_threshold_interrupt are assigned to the respective
>> function pointers when they are defined.
> The "WTF?!" would still fire and we don't want that.
Ah. Ok, I misunderstood. Will clear this.
> Also, I'm not sure about returning MCE_PANIC_SEVERITY by default.
> I mean, the code for !(Intel || AMD) has worked just fine with the
> original severities, i.e., mce_severity_intel() now.
>
> So maybe we should assign mce_severity_intel() on static init of the
> mce_severity pointer and override it only on AMD...
>
> This keeps the old behaviour for other machines, in the manner of
> letting sleeping dogs lie...
>
Ok, I'll do that and resend.
Thanks,
-Aravind.
prev parent reply other threads:[~2015-03-23 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 16:31 [PATCH V2 0/2] Rework mce_severity Aravind Gopalakrishnan
2015-03-20 16:31 ` [PATCH V2 1/2] x86, mce, severities: Add AMD severities function Aravind Gopalakrishnan
2015-03-20 16:31 ` [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer Aravind Gopalakrishnan
2015-03-20 22:31 ` Luck, Tony
2015-03-21 2:35 ` Aravind Gopalakrishnan
2015-03-21 6:10 ` Borislav Petkov
2015-03-23 14:20 ` Aravind Gopalakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55102110.4040106@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=slaoub@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.