From: Lin Ma <lma@suse.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl
Date: Mon, 23 Mar 2015 23:47:28 +0800 [thread overview]
Message-ID: <55103590.4060809@suse.com> (raw)
In-Reply-To: <551001E3.3010304@redhat.com>
在 2015年03月23日 20:06, Paolo Bonzini 写道:
>
> On 23/03/2015 11:36, Peter Crosthwaite wrote:
>> I don't think TypeInfo is the right place for this. You can however
>> define function hooks for Object in ObjectClass. See the unparent
>> field of ObjectClass for a precedent.
> In this case, the right place could be UserCreatable. Alternatively...
Well... Because I'm not familiar with qom very much, Let me dig more
details about UserCreatable first :-)
>
>> But is a better way to do this to add error handling to
>> object_unparent API and override object_unparent for your device in
>> question to throw the error? Then your change doesn't have to be
>> limited to QMP.
> ... this is also a good choice.
>
> Paolo
>
next prev parent reply other threads:[~2015-03-23 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 10:10 [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl Lin Ma
2015-03-23 10:10 ` [Qemu-devel] [PATCH 2/2] memory-backend: Add can_be_deleted impl for ram-backend and file-backend Lin Ma
2015-03-23 10:36 ` [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl Peter Crosthwaite
2015-03-23 12:06 ` Paolo Bonzini
2015-03-23 13:13 ` Andreas Färber
2015-03-23 13:30 ` Igor Mammedov
2015-03-25 15:47 ` Lin Ma
2015-03-26 10:05 ` Igor Mammedov
2015-03-26 10:07 ` Andreas Färber
2015-03-26 10:29 ` Igor Mammedov
2015-03-26 13:37 ` Paolo Bonzini
2015-03-26 14:18 ` Igor Mammedov
2015-03-23 15:47 ` Lin Ma [this message]
2015-03-23 12:52 ` Andreas Färber
2015-03-23 15:25 ` Lin Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55103590.4060809@suse.com \
--to=lma@suse.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.