From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()
Date: Mon, 23 Mar 2015 18:50:53 +0300 [thread overview]
Message-ID: <5510365D.6070109@oracle.com> (raw)
In-Reply-To: <1427121492.25985.68.camel@edumazet-glaptop2.roam.corp.google.com>
Hi Eric,
On 03/23/2015 05:38 PM, Eric Dumazet wrote:
> On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote:
> \
>> @@ -1538,7 +1525,7 @@ do_time_wait:
>> &ipv6_hdr(skb)->saddr, th->source,
>> &ipv6_hdr(skb)->daddr,
>> ntohs(th->dest), tcp_v6_iif(skb));
>> - if (sk2 != NULL) {
>> + if (sk2) {
>> struct inet_timewait_sock *tw = inet_twsk(sk);
>> inet_twsk_deschedule(tw, &tcp_death_row);
>> inet_twsk_put(tw);
> And please refrain adding such cleanup changes in a bug fix.
Sure, I will. Thank you for review!
Best regards,
Alexey
> Thanks !
>
>
prev parent reply other threads:[~2015-03-23 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 10:38 [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb() Alexey Kodanev
2015-03-23 13:52 ` Eric Dumazet
2015-03-25 21:25 ` Alexey Kodanev
2015-03-25 22:26 ` Eric Dumazet
2015-03-23 14:38 ` Eric Dumazet
2015-03-23 15:50 ` Alexey Kodanev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5510365D.6070109@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.