From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH] eal_common_options.c: set create_uio_dev option to no argument Date: Mon, 23 Mar 2015 17:13:56 +0100 Message-ID: <55103BC4.5030600@6wind.com> References: <1427098299-20876-1-git-send-email-gaohaifeng.gao@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: gaohaifeng , jerry.lilijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org, dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1427098299-20876-1-git-send-email-gaohaifeng.gao-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, On 03/23/2015 09:11 AM, gaohaifeng wrote: > From: Haifeng Gao > > eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero. > It needs to reset create_uio_dev explicitly. > > Signed-off-by: Haifeng Gao Acked-by: Olivier Matz Thank you for fixing this. Note for Thomas: the bug is there since my initial commit adding the feature, you may want to add this to the commit log: Fixes: f7f97c16048e (" pci: add option --create-uio-dev to run without hotplug") Regards, Olivier