From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752845AbbCWRKd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Mar 2015 13:10:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36620 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752285AbbCWRKa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Mar 2015 13:10:30 -0400
Message-ID: <551048E9.6060800@redhat.com>
Date: Mon, 23 Mar 2015 18:10:01 +0100
From: Denys Vlasenko <dvlasenk@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>
CC: Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: stop using PER_CPU_VAR(kernel_stack)
References: <1426970678-600-1-git-send-email-dvlasenk@redhat.com> <20150323101815.35bd61c7@gandalf.local.home>
In-Reply-To: <20150323101815.35bd61c7@gandalf.local.home>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/23/2015 03:18 PM, Steven Rostedt wrote:
> On Sat, 21 Mar 2015 21:44:37 +0100
> Denys Vlasenko <dvlasenk@redhat.com> wrote:
> 
>> Instead of PER_CPU_VAR(kernel_stack), 64-bit code
>> can use PER_CPU_VAR(cpu_tss + TSS_sp0).
> 
> The change log here is lacking an answer to "why". It only states what
> it does. What's wrong with using kernel_stack? The change log should
> explicitly state that. I have no idea why this patch is needed.

Sorry. The reason is:

We want to get rid of kernel_stack, since it is redundant:
in 64-bits, PER_CPU_VAR(cpu_tss + TSS_sp0) can be used instead,
in 32-bits, PER_CPU_VAR(cpu_current_top_of_stack) can be used instead.

Patch 2/2 in the same series removes kernel_stack.