All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	kbuild test robot <fengguang.wu@intel.com>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
Date: Tue, 24 Mar 2015 09:15:25 +0800	[thread overview]
Message-ID: <5510BAAD.3080607@huawei.com> (raw)
In-Reply-To: <CAErSpo6zfA7t-CeYx1_aBYEcV=LFueWYE_bndH-s-ktjL_goPg@mail.gmail.com>

>> sparse warnings: (new ones prefixed by >>)
>>
>>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
>>
>> Please review and possibly fold the followup patch.
> 
> It does look like pci_find_host_bridge() is only used inside
> drivers/pci/host-bridge.c and could be static.  Given that it's only
> used there, it doesn't even need to be renamed, so maybe you could
> even just drop the rename patch, too.

OK.

Hi Bjorn, because this series involved lots platforms and host bridge chips, and this version takes a lot of changes.
So I didn't take lot of time to cross build this series in all the platforms in my local. I hope you could see the changes
first, and I will refresh and fix the details soon.

Thanks!
Yijing.

> 
> Bjorn
> 
> 


-- 
Thanks!
Yijing


  reply	other threads:[~2015-03-24  1:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 18:08 [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? kbuild test robot
2015-03-23 18:08 ` [PATCH pci] PCI: pci_find_host_bridge() can be static kbuild test robot
2015-03-23 18:18 ` [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? Bjorn Helgaas
2015-03-24  1:15   ` Yijing Wang [this message]
2015-03-24  2:29     ` Bjorn Helgaas
2015-03-24  3:41       ` Yijing Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5510BAAD.3080607@huawei.com \
    --to=wangyijing@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.