From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linhaifeng Subject: Re: [PATCH v3] lib/librte_vhost: update used->idx when allocation of mbuf fails Date: Tue, 24 Mar 2015 15:46:32 +0800 Message-ID: <55111658.9060707@huawei.com> References: <1426902420-21492-1-git-send-email-haifeng.lin@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Xie, Huawei" , "Ouyang, Changchun" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/3/24 15:14, Xie, Huawei wrote: > On 3/22/2015 8:08 PM, Ouyang, Changchun wrote: >> >>> -----Original Message----- >>> From: linhaifeng [mailto:haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org] >>> Sent: Saturday, March 21, 2015 9:47 AM >>> To: dev-VfR2kkLFssw@public.gmane.org >>> Cc: Ouyang, Changchun; Xie, Huawei >>> Subject: [PATCH v3] lib/librte_vhost: update used->idx when allocation of >>> mbuf fails >>> >>> From: Linhaifeng >>> >>> When failed to malloc buffer from mempool we just update last_used_idx >>> but not used->idx so after many times vhost thought have handle all packets >>> but virtio_net thought vhost have not handle all packets and will not update >>> avail->idx. >>> >>> Signed-off-by: Linhaifeng >> Acked-by: Changchun Ouyang >> >> >> > Acked-by: Huawei Xie > > This patch fix the issue. > Simple solution like other PMDs is before processing one descriptor, > ensure allocation of new mbuf is successfull, and then immediately > refill after receiving the packet from the descriptor. > In future, we should consider optimized bulk allocation strategy with > threshold. > Hi, huawei THis is patch is for librte_vhost. Do you want to ack for the other patch for virtio-net-pmd? > > > > > -- Regards, Haifeng