From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 24 Mar 2015 10:00:04 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:26411 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006953AbbCXJACrmNEW (ORCPT ); Tue, 24 Mar 2015 10:00:02 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id E822DBB377896; Tue, 24 Mar 2015 08:59:55 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 24 Mar 2015 08:59:57 +0000 Received: from [192.168.154.138] (192.168.154.138) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Tue, 24 Mar 2015 08:59:57 +0000 Message-ID: <5511278D.4030109@imgtec.com> Date: Tue, 24 Mar 2015 08:59:57 +0000 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: Subject: Re: [PATCH 1/4] MIPS: asm: r4kcache: Use correct base register for MIPS R6 cache flushes References: <1425408530-21613-1-git-send-email-markos.chandras@imgtec.com> <1425408530-21613-2-git-send-email-markos.chandras@imgtec.com> <54FD5D34.7060201@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.138] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 46505 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 03/23/2015 08:40 PM, Maciej W. Rozycki wrote: > On Mon, 9 Mar 2015, Markos Chandras wrote: > >>> Since this operates on addresses shouldn't PTR_ADDIU be used instead? >>> >>> Maciej >>> >> >> I don't know. I thought PTR_ADDIU should be used for pointers but the >> arguments in these macros are "unsigned long". > > Hmm, good point. I think we should match the C data type used even > though we have an assumption that sizeof(long) == sizeof(void *), so your > change looks right to me as it stands. > > I think we have a convention to separate `linux' from `asm' inclusions by > an empty line though, so I suggest that you add one here: > >> diff --git a/arch/mips/include/asm/r4kcache.h b/arch/mips/include/asm/r4kcache.h >> index 1b22d2da88a1..d329f7328bd4 100644 >> --- a/arch/mips/include/asm/r4kcache.h >> +++ b/arch/mips/include/asm/r4kcache.h >> @@ -12,6 +12,7 @@ >> #ifndef _ASM_R4KCACHE_H >> #define _ASM_R4KCACHE_H >> >> +#include >> #include >> #include >> #include > > as well. I can offer you my review tag if you repost the change with this > trivial update. > > Maciej > Hi, I believe Ralf can fix this trivial change whenever he gets to apply these patches. If not, I will post it again. -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:26411 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006953AbbCXJACrmNEW (ORCPT ); Tue, 24 Mar 2015 10:00:02 +0100 Message-ID: <5511278D.4030109@imgtec.com> Date: Tue, 24 Mar 2015 08:59:57 +0000 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH 1/4] MIPS: asm: r4kcache: Use correct base register for MIPS R6 cache flushes References: <1425408530-21613-1-git-send-email-markos.chandras@imgtec.com> <1425408530-21613-2-git-send-email-markos.chandras@imgtec.com> <54FD5D34.7060201@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: "Maciej W. Rozycki" Cc: linux-mips@linux-mips.org Message-ID: <20150324085957.WrGYl7lMWuK9WZOxg1GRTyo_waJDPxnY2EPNPYowndA@z> On 03/23/2015 08:40 PM, Maciej W. Rozycki wrote: > On Mon, 9 Mar 2015, Markos Chandras wrote: > >>> Since this operates on addresses shouldn't PTR_ADDIU be used instead? >>> >>> Maciej >>> >> >> I don't know. I thought PTR_ADDIU should be used for pointers but the >> arguments in these macros are "unsigned long". > > Hmm, good point. I think we should match the C data type used even > though we have an assumption that sizeof(long) == sizeof(void *), so your > change looks right to me as it stands. > > I think we have a convention to separate `linux' from `asm' inclusions by > an empty line though, so I suggest that you add one here: > >> diff --git a/arch/mips/include/asm/r4kcache.h b/arch/mips/include/asm/r4kcache.h >> index 1b22d2da88a1..d329f7328bd4 100644 >> --- a/arch/mips/include/asm/r4kcache.h >> +++ b/arch/mips/include/asm/r4kcache.h >> @@ -12,6 +12,7 @@ >> #ifndef _ASM_R4KCACHE_H >> #define _ASM_R4KCACHE_H >> >> +#include >> #include >> #include >> #include > > as well. I can offer you my review tag if you repost the change with this > trivial update. > > Maciej > Hi, I believe Ralf can fix this trivial change whenever he gets to apply these patches. If not, I will post it again. -- markos