From: Michael Wood <michael.g.wood@intel.com>
To: "Barros Pena, Belen" <belen.barros.pena@intel.com>,
"toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] bbarrosp/ui-fixes
Date: Tue, 24 Mar 2015 11:42:28 +0000 [thread overview]
Message-ID: <55114DA4.3020400@intel.com> (raw)
In-Reply-To: <D136FB89.57A44%belen.barros.pena@intel.com>
On 24/03/15 11:35, Barros Pena, Belen wrote:
>
> On 24/03/2015 11:29, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> Looks good to me.
>>
>> Thanks
>>
>> Related comment (but not impacting on this review) - I've always found
>> it weird that releases == git branches in toaster, that seems like an
>> implementation detail to me, as in other projects a release could be a
>> git tag or a tarball or a commit or any of the 100s of ways of
>> distributing code.
> I didn't think this was the case. I was under the impression that a
> release was a combination of a BitBake version and a OE metadata version.
> What that version is set to (a branch, a git tag or a commit) should be
> irrelevant (we should be supporting all 3, but not tarballs I think).
>
> What makes you think that a release must be a git branch?
The configuration for the release field names are "branch" and "up_branch"
(http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto/conf/toasterconf.json?#n62)
> Cheers
>
> Belén
>
>
>> On 22/03/15 20:17, belen barros pena wrote:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui
>>> -fixes
>>>
>>> a8a5552ad7d3ba869f165ef4a392990263224428
>>> bitbake: toasterui: hide right column if empty
>>>
>>> cf44f4dfe7a6dec273d77143dbe19eeab1ae23d5
>>> bitbake: toasterui: Improve messaging for empty layer details
>>>
>>> 09246f125cea1f8ff81081492824e14a3d38b02c
>>> bitbake: toasterui: hide release when only one exists
>>>
>>> a2ffbc6f186f7d7fb022c8bfcd5b01a1a3442bb6
>>> bitbake: toaster: update OpenEmbedded Toaster configuration
>>>
>>> 015fac8c6ef58218c8ad75d375907f13ac021548
>>> bitbake: toaster: update Yocto Project Toaster configuration
>>>
>>> Thanks,
>>>
>>> Belén
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
next prev parent reply other threads:[~2015-03-24 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 20:17 [review-request] bbarrosp/ui-fixes belen barros pena
2015-03-24 11:29 ` Michael Wood
2015-03-24 11:35 ` Barros Pena, Belen
2015-03-24 11:42 ` Michael Wood [this message]
2015-03-24 17:28 ` Damian, Alexandru
2015-03-24 17:35 ` Damian, Alexandru
-- strict thread matches above, loose matches on Subject: below --
2015-03-03 10:05 Barros Pena, Belen
2015-03-09 12:27 ` Damian, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55114DA4.3020400@intel.com \
--to=michael.g.wood@intel.com \
--cc=belen.barros.pena@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.