From: Daniel Borkmann <daniel@iogearbox.net>
To: Michal Sekletar <msekleta@redhat.com>, netdev@vger.kernel.org
Cc: Alexei Starovoitov <ast@plumgrid.com>, Jiri Pirko <jpirko@redhat.com>
Subject: Re: [PATCH net-next v3] filter: introduce SKF_AD_VLAN_TPID BPF extension
Date: Tue, 24 Mar 2015 14:55:17 +0100 [thread overview]
Message-ID: <55116CC5.4000706@iogearbox.net> (raw)
In-Reply-To: <1427204921-14535-1-git-send-email-msekleta@redhat.com>
On 03/24/2015 02:48 PM, Michal Sekletar wrote:
> If vlan offloading takes place then vlan header is removed from frame
> and its contents, both vlan_tci and vlan_proto, is available to user
> space via TPACKET interface. However, only vlan_tci can be used in BPF
> filters.
>
> This commit introduces a new BPF extension. It makes possible to load
> the value of vlan_proto (vlan TPID) to register A. Support for classic
> BPF and eBPF is being added, analogous to skb->protocol.
>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Alexei Starovoitov <ast@plumgrid.com>
> Cc: Jiri Pirko <jpirko@redhat.com>
>
> Signed-off-by: Michal Sekletar <msekleta@redhat.com>
Looks good to me, thanks!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2015-03-24 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 13:48 [PATCH net-next v3] filter: introduce SKF_AD_VLAN_TPID BPF extension Michal Sekletar
2015-03-24 13:55 ` Daniel Borkmann [this message]
2015-03-24 15:17 ` Alexei Starovoitov
2015-03-24 15:44 ` Jiri Pirko
2015-03-24 19:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55116CC5.4000706@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@plumgrid.com \
--cc=jpirko@redhat.com \
--cc=msekleta@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.