From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 1/2] introduce gprintk()
Date: Tue, 24 Mar 2015 15:12:16 +0000
Message-ID: <55117ED0.30509@linaro.org>
References: <550C44F1020000780006C1A5@mail.emea.novell.com>	<550C46F0020000780006C1C1@mail.emea.novell.com>
	<1427206853.21742.402.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YaQVA-0002L5-Q6
	for xen-devel@lists.xenproject.org; Tue, 24 Mar 2015 15:12:20 +0000
Received: by wgbcc7 with SMTP id cc7so173560342wgb.0
	for <xen-devel@lists.xenproject.org>;
	Tue, 24 Mar 2015 08:12:19 -0700 (PDT)
In-Reply-To: <1427206853.21742.402.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Julien Grall <julien.grall@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 24/03/2015 14:20, Ian Campbell wrote:
> @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
>           break;
>       default:
>           {
> -#ifndef NDEBUG
>               struct hsr_cp64 cp64 = hsr.cp64;
>
>               gdprintk(XENLOG_ERR,
> @@ -1718,7 +1715,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
>                        cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
>               gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n",
>                        hsr.bits & HSR_CP64_REGS_MASK);
> -#endif

Did you try to build with debug=n ? I suspect that GCC will warn about 
the unused cp64.

Regards,

-- 
Julien Grall