From: Julien Grall <julien.grall@linaro.org>
To: Robert VanVossen <robert.vanvossen@dornerworks.com>,
xen-devel@lists.xenproject.org
Cc: julien.grall@citrix.com, edgar.iglesias@xilinx.com,
Josh.Whitehead@dornerworks.com, Ian.Campbell@citrix.com,
Stefano.Stabellini@eu.citrix.com
Subject: Re: [PATCH v2] xen/passthrough: Support a single iommu_domain per xen domain per SMMU
Date: Tue, 24 Mar 2015 15:19:17 +0000 [thread overview]
Message-ID: <55118075.80404@linaro.org> (raw)
In-Reply-To: <55117DCF.9070504@dornerworks.com>
On 24/03/2015 15:07, Robert VanVossen wrote:
> Hello Julien,
Hello Robert,
> On 3/23/2015 5:53 PM, Julien Grall wrote:
> But don't we need to handle the failure of attach_dev differently based on which
> fails? If the attach_dev fails on a new iommu_domain, then the iommu_domain
> should be destroyed. If it fails on a preexisting iommu_domain that is already
> attached to another device, then you don't want to destroy the iommu_domain.
It should be covered by
if (failed && atomic == 0)
destroy iommu_domain.
If you prefer to keep the 2 possible case separate, I would still like
to have a separate helper to get the domain.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-03-24 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 13:46 [PATCH v2] xen/passthrough: Support a single iommu_domain per xen domain per SMMU Robbie VanVossen
2015-03-23 21:53 ` Julien Grall
2015-03-24 15:07 ` Robert VanVossen
2015-03-24 15:19 ` Julien Grall [this message]
2015-03-24 11:07 ` Manish Jaggi
2015-03-24 14:04 ` Robert VanVossen
2015-03-25 4:58 ` Manish Jaggi
2015-03-25 17:35 ` Stefano Stabellini
2015-03-30 11:04 ` Manish Jaggi
2015-03-30 11:40 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55118075.80404@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Josh.Whitehead@dornerworks.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=edgar.iglesias@xilinx.com \
--cc=julien.grall@citrix.com \
--cc=robert.vanvossen@dornerworks.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.