From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 1/2] introduce gprintk()
Date: Tue, 24 Mar 2015 15:36:57 +0000
Message-ID: <55118499.7080901@linaro.org>
References: <550C44F1020000780006C1A5@mail.emea.novell.com>
	<550C46F0020000780006C1C1@mail.emea.novell.com>
	<1427206853.21742.402.camel@citrix.com> <55117ED0.30509@linaro.org>
	<55119152020000780006D129@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YaQt3-0006XC-7i
	for xen-devel@lists.xenproject.org; Tue, 24 Mar 2015 15:37:01 +0000
Received: by wibdy8 with SMTP id dy8so78285979wib.0
	for <xen-devel@lists.xenproject.org>;
	Tue, 24 Mar 2015 08:36:59 -0700 (PDT)
In-Reply-To: <55119152020000780006D129@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

Hi Jan,

On 24/03/2015 15:31, Jan Beulich wrote:
>>>> On 24.03.15 at 16:12, <julien.grall@linaro.org> wrote:
>> Hi Ian,
>>
>> On 24/03/2015 14:20, Ian Campbell wrote:
>>> @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
>>>            break;
>>>        default:
>>>            {
>>> -#ifndef NDEBUG
>>>                struct hsr_cp64 cp64 = hsr.cp64;
>>>
>>>                gdprintk(XENLOG_ERR,
>>> @@ -1718,7 +1715,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
>>>                         cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
>>>                gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n",
>>>                         hsr.bits & HSR_CP64_REGS_MASK);
>>> -#endif
>>
>> Did you try to build with debug=n ? I suspect that GCC will warn about
>> the unused cp64.
>
> I don't think so - gdprintk() in the NDEBUG case is specifically an
> inline function instead of a macro, to avoid this very issue.

I wasn't sure about it. So

Reviewed-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall