From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, suravee.suthikulpanit@amd.com,
andrew.cooper3@citrix.com, tim@xen.org,
dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org,
Aravind.Gopalakrishnan@amd.com, jun.nakajima@intel.com,
dgdegra@tycho.nsa.gov
Subject: Re: [PATCH v19 11/14] x86/VPMU: Handle PMU interrupts for PV guests
Date: Tue, 24 Mar 2015 11:47:12 -0400 [thread overview]
Message-ID: <55118700.9050204@oracle.com> (raw)
In-Reply-To: <5511928F020000780006D13E@mail.emea.novell.com>
On 03/24/2015 11:36 AM, Jan Beulich wrote:
>>>> On 24.03.15 at 16:13, <boris.ostrovsky@oracle.com> wrote:
>> On 03/24/2015 10:28 AM, Jan Beulich wrote:
>>>>>> On 17.03.15 at 15:54, <boris.ostrovsky@oracle.com> wrote:
>>>> Changes in v19:
>>>> * Adjusted for new ops interfaces (passing vcpu vs. vpmu)
>>>> * Test for domain->max_cpu in choose_hwdom_vcpu() instead of
>>>> 'domain->vcpu!=NULL'
>>> I suppose that's something that then should also be done in patch 7?
>> We only need this routine during interrupt handling (for PV(H)) and this
>> is the patch that introduces this functionality.
>>
>> And if you are asking about the test specifically --- this is also the
>> first patch where we refer to hardware_domain->vcpu[], which is what the
>> test is really for.
>>
>> Or is it something else that you had in mind?
> Yes - following Andrew's cleanup I believe the d->vcpu != NULL
> check is redundant with having (perhaps indirectly)
> checked d->max_vcpus > 0.
Then I am not sure I understand what you are asking me to do for patch
7, sorry.
-boris
next prev parent reply other threads:[~2015-03-24 15:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 14:53 [PATCH v19 00/14] x86/PMU: Xen PMU PV(H) support Boris Ostrovsky
2015-03-17 14:53 ` [PATCH v19 01/14] x86/VPMU: VPMU should not exist when vpmu_initialise() is called Boris Ostrovsky
2015-03-19 8:43 ` Dietmar Hahn
2015-03-17 14:53 ` [PATCH v19 02/14] common/symbols: Export hypervisor symbols to privileged guest Boris Ostrovsky
2015-03-17 14:54 ` [PATCH v19 03/14] x86/VPMU: Add public xenpmu.h Boris Ostrovsky
2015-03-17 14:54 ` [PATCH v19 04/14] x86/VPMU: Make vpmu not HVM-specific Boris Ostrovsky
2015-03-17 14:54 ` [PATCH v19 05/14] x86/VPMU: Interface for setting PMU mode and flags Boris Ostrovsky
2015-03-19 13:12 ` Dietmar Hahn
2015-03-19 13:28 ` Jan Beulich
2015-03-19 13:49 ` Dietmar Hahn
2015-03-24 13:56 ` Jan Beulich
2015-03-17 14:54 ` [PATCH v19 06/14] x86/VPMU: Initialize VPMUs with __initcall Boris Ostrovsky
2015-03-17 14:54 ` [PATCH v19 07/14] x86/VPMU: Initialize PMU for PV(H) guests Boris Ostrovsky
2015-03-24 14:08 ` Jan Beulich
2015-03-24 15:06 ` Boris Ostrovsky
2015-03-17 14:54 ` [PATCH v19 08/14] x86/VPMU: Save VPMU state for PV guests during context switch Boris Ostrovsky
2015-03-24 14:15 ` Jan Beulich
2015-03-17 14:54 ` [PATCH v19 09/14] x86/VPMU: When handling MSR accesses, leave fault injection to callers Boris Ostrovsky
2015-03-17 14:54 ` [PATCH v19 10/14] x86/VPMU: Add support for PMU register handling on PV guests Boris Ostrovsky
2015-03-17 14:54 ` [PATCH v19 11/14] x86/VPMU: Handle PMU interrupts for " Boris Ostrovsky
2015-03-24 14:28 ` Jan Beulich
2015-03-24 15:13 ` Boris Ostrovsky
2015-03-24 15:36 ` Jan Beulich
2015-03-24 15:47 ` Boris Ostrovsky [this message]
2015-03-24 16:03 ` Jan Beulich
2015-03-17 14:54 ` [PATCH v19 12/14] x86/VPMU: Merge vpmu_rdmsr and vpmu_wrmsr Boris Ostrovsky
2015-03-25 8:29 ` Dietmar Hahn
2015-03-25 12:23 ` Dietmar Hahn
2015-03-25 16:52 ` Jan Beulich
2015-03-17 14:54 ` [PATCH v19 13/14] x86/VPMU: Add privileged PMU mode Boris Ostrovsky
2015-03-25 12:25 ` Dietmar Hahn
2015-03-25 16:57 ` Jan Beulich
2015-03-17 14:54 ` [PATCH v19 14/14] x86/VPMU: Move VPMU files up from hvm/ directory Boris Ostrovsky
2015-03-19 14:32 ` [PATCH v19 00/14] x86/PMU: Xen PMU PV(H) support Dietmar Hahn
2015-03-19 16:03 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55118700.9050204@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.