From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: Hannes Reinecke <hare@suse.de>, JBottomley@parallels.com
Cc: joe@perches.com, Elliott@hp.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] aic7xxx: replace kmalloc/memset by kzalloc
Date: Tue, 24 Mar 2015 13:46:08 -0700 [thread overview]
Message-ID: <5511CD10.6040709@free-electrons.com> (raw)
In-Reply-To: <550FB9BE.5010801@suse.de>
Hi,
On 03/22/2015 11:59 PM, Hannes Reinecke wrote:
> On 03/22/2015 05:31 PM, Michael Opdenacker wrote:
>> This replaces kmalloc + memset by a call to kzalloc
>> (or kcalloc when appropriate, which zeroes memory too)
>>
>> This also fixes one checkpatch.pl issue in the process.
>>
>> This improvement was suggested by "make coccicheck"
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
I'm sending a version that reverts the use of kcalloc() instead of
kzalloc(). For reasons I don't understand, I didn't see the end of
Robert Elliott's comment that the use of kcalloc() could prevent the
compiler from detecting an overflow.
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
next prev parent reply other threads:[~2015-03-24 20:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 19:14 [PATCH] aic7xxx: replace kmalloc/memset by kzalloc Michael Opdenacker
2014-10-16 19:28 ` Joe Perches
2014-10-16 19:30 ` Michael Opdenacker
2014-10-16 20:05 ` Elliott, Robert (Server Storage)
2015-03-22 16:31 ` [PATCH] [RESEND] " Michael Opdenacker
2015-03-23 6:59 ` Hannes Reinecke
2015-03-24 20:46 ` Michael Opdenacker [this message]
2015-03-24 20:57 ` Joe Perches
2015-03-24 23:16 ` Elliott, Robert (Server Storage)
2015-03-27 0:38 ` Michael Opdenacker
2015-03-27 0:51 ` Michael Opdenacker
2015-03-27 19:48 ` kcalloc/kmalloc_array could BUILD_BUG_ON for too-big constant arguments (was Re: [PATCH] [RESEND] aic7xxx: replace kmalloc/memset by kzalloc) Jeff Epler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5511CD10.6040709@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=Elliott@hp.com \
--cc=JBottomley@parallels.com \
--cc=hare@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.