From: David Ahern <david.ahern@oracle.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf timechart: Fix SIBGUS error on sparc64
Date: Tue, 24 Mar 2015 15:28:26 -0600 [thread overview]
Message-ID: <5511D6FA.2010801@oracle.com> (raw)
In-Reply-To: <20150324211530.GL5447@kernel.org>
On 3/24/15 3:15 PM, Arnaldo Carvalho de Melo wrote:
> /me scratches head, should be missing something embarassingly simple :-/
>
ptr = sample->raw_data + field->offset;
raw_data is *guaranteed* to be misaligned. From kernel/events/core.c:
struct {
u32 size;
u32 data;
} raw = {
.size = sizeof(u32),
.data = 0,
};
Raw data starts at 64-bit alignment, but that u32 means data is NOT
8-byte aligned. :-(
David
next prev parent reply other threads:[~2015-03-24 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 20:14 [PATCH] perf timechart: Fix SIBGUS error on sparc64 David Ahern
2015-03-24 21:15 ` Arnaldo Carvalho de Melo
2015-03-24 21:28 ` David Ahern [this message]
2015-03-27 7:39 ` [tip:perf/core] " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5511D6FA.2010801@oracle.com \
--to=david.ahern@oracle.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.