From: Randy Witt <randy.e.witt@linux.intel.com>
To: Tyler Hall <tylerwhall@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] uninative-tarball: fix dependency on patchelf
Date: Tue, 24 Mar 2015 15:31:08 -0700 [thread overview]
Message-ID: <5511E5AC.3080202@linux.intel.com> (raw)
In-Reply-To: <1427235430-20299-1-git-send-email-tylerwhall@gmail.com>
On 03/24/2015 03:17 PM, Tyler Hall wrote:
> DEPENDS doesn't actually add the dependency on patchelf-native to the
> populate_sdk task. SDK_DEPENDS does this, but move the append to after
> inheriting the base class so it does not get overwritten.
>
> Without this, uninative-tarball fails to build in a clean workspace on a
> system without patchelf.
>
> Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
> CC: Richard Purdie <richard.purdie@linuxfoundation.org>
> CC: Randy Witt <randy.e.witt@linux.intel.com>
> ---
> meta/recipes-core/meta/uninative-tarball.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb
> index 53435f2..62bdde8 100644
> --- a/meta/recipes-core/meta/uninative-tarball.bb
> +++ b/meta/recipes-core/meta/uninative-tarball.bb
> @@ -11,7 +11,6 @@ TOOLCHAIN_HOST_TASK = "\
> "
>
> INHIBIT_DEFAULT_DEPS = "1"
> -DEPENDS += "patchelf-native"
>
> TOOLCHAIN_OUTPUTNAME ?= "${BUILD_ARCH}-nativesdk-libc"
>
> @@ -25,6 +24,8 @@ inherit populate_sdk
> deltask install
> deltask package
>
> +SDK_DEPENDS += "patchelf-native"
> +
> SDK_PACKAGING_FUNC = ""
>
> fakeroot create_sdk_files() {
>
This patch is the same as what I had queued up. The only thing is to put the
yocto bug number 7467 in the commit message.
Acked-by: Randy Witt <randy.e.witt@linux.intel.com>
next prev parent reply other threads:[~2015-03-24 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 22:17 [PATCH] uninative-tarball: fix dependency on patchelf Tyler Hall
2015-03-24 22:31 ` Randy Witt [this message]
2015-03-25 17:35 ` [PATCH v2] " Tyler Hall
2015-03-25 17:43 ` Tyler Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5511E5AC.3080202@linux.intel.com \
--to=randy.e.witt@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tylerwhall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.