All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARM: at91: at91sam9n12ek: save the environment to a fat file in MMC card
Date: Wed, 25 Mar 2015 11:54:40 +0800	[thread overview]
Message-ID: <55123180.5040100@atmel.com> (raw)
In-Reply-To: <1427188042-18122-1-git-send-email-josh.wu@atmel.com>

Hi Josh,

On 03/24/2015 05:07 PM, Josh Wu wrote:
> Insteading in mmc's raw sectors, this patch will save the environment
> in a fat file (uboot.env) in mmc card's first FAT patition by default.
>
> If you want to save in mmc's raw sectors, you only need to define
> CONFIG_ENV_IS_IN_MMC.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>

Thanks for your patch. I think this one is better than v1.

Acked-by: Bo Shen <voice.shen@atmel.com>

> ---
>
> Changes in v2:
> - not remove the code to save env in mmc's raw sectors.
> - we can define CONFIG_ENV_IS_IN_MMC to enable raw sectors saving.
>
>   include/configs/at91sam9n12ek.h | 15 +++++++++++++--
>   1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/at91sam9n12ek.h b/include/configs/at91sam9n12ek.h
> index f02fce9..058e0e4 100644
> --- a/include/configs/at91sam9n12ek.h
> +++ b/include/configs/at91sam9n12ek.h
> @@ -201,11 +201,22 @@
>   #else /* CONFIG_SYS_USE_MMC */
>
>   /* bootstrap + u-boot + env + linux in mmc */
> -#define CONFIG_ENV_IS_IN_MMC
> -/* For FAT system, most cases it should be in the reserved sector */
> +
> +#ifdef CONFIG_ENV_IS_IN_MMC
> +/* Use raw reserved sectors to save environment */
>   #define CONFIG_ENV_OFFSET		0x2000
>   #define CONFIG_ENV_SIZE			0x1000
>   #define CONFIG_SYS_MMC_ENV_DEV		0
> +#else
> +/* Use file in FAT file to save environment */
> +#define CONFIG_ENV_IS_IN_FAT
> +#define CONFIG_FAT_WRITE
> +#define FAT_ENV_INTERFACE		"mmc"
> +#define FAT_ENV_FILE			"uboot.env"
> +#define FAT_ENV_DEVICE_AND_PART		"0"
> +#define CONFIG_ENV_SIZE			0x4000
> +#endif
> +
>   #define CONFIG_BOOTCOMMAND						\
>   	"setenv bootargs ${console} ${mtdparts} ${bootargs_mmc};"	\
>   	"fatload mmc 0:1 0x21000000 dtb;"				\
>

Best Regards,
Bo Shen

  reply	other threads:[~2015-03-25  3:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24  9:07 [U-Boot] [PATCH v2] ARM: at91: at91sam9n12ek: save the environment to a fat file in MMC card Josh Wu
2015-03-25  3:54 ` Bo Shen [this message]
2015-03-31 23:06 ` [U-Boot] [U-Boot, " Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55123180.5040100@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.