From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36652)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YalHL-0004FO-NR
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:23:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YalHG-0004hF-Hz
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:23:27 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:14029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YalHG-0004gE-Cr
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:23:22 -0400
Message-ID: <5512B6C3.2060005@imgtec.com>
Date: Wed, 25 Mar 2015 13:23:15 +0000
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <CAL5wTH4-=HJUvwBu+2o6jGanJesJOyNf3sL8-5+d_-6C3cWBfA@mail.gmail.com>
	<5511ECD4.1030507@suse.de>
In-Reply-To: <5511ECD4.1030507@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace
 memory_region_init_ram with memory_region_allocate_system_memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, =?UTF-8?B?RGlyayA=?= =?UTF-8?B?TcO8bGxlcg==?= <dirk@dmllr.de>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>, =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, Aurelien Jarno <aurelien@aurel32.net>

On 24/03/2015 23:01, Andreas F=C3=A4rber wrote:
> Am 24.03.2015 um 22:28 schrieb Dirk M=C3=BCller:
>> Commit 0b183fc871:"memory: move mem_path handling to
>> memory_region_allocate_system_memory" split memory_region_init_ram and
>> memory_region_init_ram_from_file. Also it moved mem-path handling a st=
ep
>> up from memory_region_init_ram to memory_region_allocate_system_memory=
.
>>
>> Therefore for any board that uses memory_region_init_ram directly,
>> -mem-path is not supported.
>>
>> Fix this by replacing memory_region_init_ram with
>> memory_region_allocate_system_memory.
>>
>> Signed-off-by: Dirk Mueller <dmueller@suse.com>
>> ---
>>  hw/mips/mips_fulong2e.c | 3 +--
>>  hw/mips/mips_jazz.c     | 5 ++---
>>  hw/mips/mips_malta.c    | 5 ++---
>>  hw/mips/mips_mipssim.c  | 5 ++---
>>  hw/mips/mips_r4k.c      | 3 +--
>>  5 files changed, 8 insertions(+), 13 deletions(-)
>=20
> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>
>=20
> Leon and Paolo, I assume one of you will be handling this?
>=20

Acked-by: Leon Alrae <leon.alrae@imgtec.com>

Paolo, is this going via your memory API pullreq?

Regards,
Leon